From patchwork Wed Dec 13 04:54:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changwei Ge X-Patchwork-Id: 10109207 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E58B060352 for ; Wed, 13 Dec 2017 04:55:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD8A0286D7 for ; Wed, 13 Dec 2017 04:55:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D265528707; Wed, 13 Dec 2017 04:55:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 523E5286D7 for ; Wed, 13 Dec 2017 04:55:49 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBD4pxum180539; Wed, 13 Dec 2017 04:54:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2017-10-26; bh=g7R7jF+m8Vf4OqYjAmubukD2ISvObV3sHkf2EgsB/e8=; b=r5a3dKkkuLTGubuPNW/ADv4Nlr/aeTNv/Ef+jNnrLfFvjBN3cCnSBPD3rM6Vlhg3SnQH pOK/LCzTWlfyrY+86W/DaXTKcyTpBCtCR/QBR0U7vH00lg4Ra/jkkHQR8CRpgtrHSyV0 afGAOg48vfGNDnAA7XMrOlmB0iDD+lYp5mIpY/8cZ1e21X/RHTjUM3/+ZWIM8s2K4MPb iYkdgTZv6v//JJNfc/idq8T6J+gmdNT9Z530nKLCb1UVILdYvUiTaAa5GHMdHFV8PGKR +WQ9E4+333r7xYhqQee4eBJl1mdMAok97QH8rNmFeaE3YP4GR/TRXnEs7vY4IK0w5GVx og== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2etwer81fp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2017 04:54:49 +0000 Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vBD4smfP019009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Dec 2017 04:54:49 GMT Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1eOz4C-0005FR-Gj; Tue, 12 Dec 2017 20:54:48 -0800 Received: from userv0021.oracle.com ([156.151.31.71]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1eOz4B-0005FG-IY for ocfs2-devel@oss.oracle.com; Tue, 12 Dec 2017 20:54:47 -0800 Received: from userp2030.oracle.com (userp2030.oracle.com [156.151.31.89]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vBD4slvS018977 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK) for ; Wed, 13 Dec 2017 04:54:47 GMT Received: from pps.filterd (userp2030.oracle.com [127.0.0.1]) by userp2030.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBD4pvsd033705 for ; Wed, 13 Dec 2017 04:54:47 GMT Received: from h3cmg01-ex.h3c.com (smtp.h3c.com [60.191.123.56]) by userp2030.oracle.com with ESMTP id 2etvqk94cr-1 for ; Wed, 13 Dec 2017 04:54:46 +0000 Received: from BJHUB01-EX.srv.huawei-3com.com (unknown [10.63.20.169]) by h3cmg01-ex.h3c.com with smtp id 7f9d_0709_42f4dae8_8fd6_46f4_9eba_94927c33b929; Wed, 13 Dec 2017 12:54:40 +0800 Received: from H3CMLB14-EX.srv.huawei-3com.com ([fe80::f804:6772:bd71:f07f]) by BJHUB01-EX.srv.huawei-3com.com ([::1]) with mapi id 14.03.0248.002; Wed, 13 Dec 2017 12:54:30 +0800 From: Changwei Ge To: Andrew Morton , "ocfs2-devel@oss.oracle.com" , Joseph Qi Thread-Topic: [PATCH v3] ocfs2: clean dead code in suballoc.c Thread-Index: AdNzznVkPCLy60j5Qe+5+BhTeTQdHw== Date: Wed, 13 Dec 2017 04:54:29 +0000 Message-ID: <63ADC13FD55D6546B7DECE290D39E373F1F5A8DD@H3CMLB14-EX.srv.huawei-3com.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.125.136.231] MIME-Version: 1.0 X-CLX-Shades: MLX X-CLX-Response: 1TFkXGx0SEQpMehcaEQpZTRdnZnIRCllJFxpxGhAadwYbHxJxGR0QGncGGBo GGhEKWV4XaG55EQpJRhdFWEtJRk91WlhFTl9JXkNFRBl1T0sRCkNOFx9lWl1YZWNhc15ZbhNcWQ d4HkIeRn8SbWVZf0lkch4eEQpYXBcfBBoEGxgYBxxLSEtPHhwaBRsaBBsaGgQeEgQfEBseGh8aE QpeWRd4cEZJUxEKTVwXGBMcEQpMWhdoaUJNexEKTU4XaBEKTEYXY2sRCkNaFxwaBBsTGwQbGBkE HxwRCkJeFxsRCkReFx4RCkJGF2xCWGl8QkZweRofEQpCXBcaEQpCRRduGVhMXmEBcFJMYREKQk4 XZEJ8WkVEQWIdZFARCkJMF29+XU0YBV1mGlJ7EQpCbBdkYU9LYEJIEngdZxEKQkAXYl9OaEMaZV NuXFwRCkJYF2J9b3kBTxgZcHB7EQpNXhcbEQpwaBdhAWEbYxxFX3B7fhAaEQpwaBd6fRNJE3JfH nJwTxAZGhEKcGgXZhtMUBtrS2IFXRgQGhEKcGgXbX5OcFlTRm9mZmQQGhEKcGgXaEsdQHhPcllg ehIQGhEKcGwXbU4bb1MBR1JIHXMQHhIRCm1+FxsRClhNF0sRIA== X-PDR: PASS X-Source-IP: 60.191.123.56 X-ServerName: smtp.h3c.com X-Proofpoint-SPF-Result: temperror X-Proofpoint-SPF-Record: N/A X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=178 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130068 X-Spam: Clean Subject: [Ocfs2-devel] [PATCH v3] ocfs2: clean dead code in suballoc.c X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130068 X-Virus-Scanned: ClamAV using ClamSMTP Stack variable fe is no longer used, so trim it to save some CPU cycles and stack space. Signed-off-by: Changwei Ge Reviewed-by: Joseph Qi --- fs/ocfs2/suballoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index 71f22c8fbffd..508422b0032f 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c @@ -2566,16 +2566,16 @@ static int _ocfs2_free_clusters(handle_t *handle, int status; u16 bg_start_bit; u64 bg_blkno; - struct ocfs2_dinode *fe; /* You can't ever have a contiguous set of clusters * bigger than a block group bitmap so we never have to worry * about looping on them. * This is expensive. We can safely remove once this stuff has * gotten tested really well. */ - BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk))); + BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, + ocfs2_blocks_to_clusters(bitmap_inode->i_sb, + start_blk))); - fe = (struct ocfs2_dinode *) bitmap_bh->b_data; ocfs2_block_to_cluster_group(bitmap_inode, start_blk, &bg_blkno, &bg_start_bit);