| Message ID | 1513602150-7542-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Fabio, On 12/18/2017 02:02 PM, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > devm_ioremap_resource() already checks if the resource is NULL, so > remove the unnecessary platform_get_resource() error check. > > Cc: Archit Taneja <architt@codeaurora.org> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index d9cca4f..5db4cbb 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > > if (!plat_data->base) { > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return ERR_PTR(-ENODEV); > - Many thanks for this cleanup. Reviewed-by: Philippe Cornu <philippe.cornu@st.com> Philippe :-) > dsi->base = devm_ioremap_resource(dev, res); > if (IS_ERR(dsi->base)) > return ERR_PTR(-ENODEV); >
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index d9cca4f..5db4cbb 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, if (!plat_data->base) { res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return ERR_PTR(-ENODEV); - dsi->base = devm_ioremap_resource(dev, res); if (IS_ERR(dsi->base)) return ERR_PTR(-ENODEV);