[-next] PM / OPP: Make local function ti_opp_supply_set_opp() static
diff mbox

Message ID 1513748680-163750-1-git-send-email-weiyongjun1@huawei.com
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Wei Yongjun Dec. 20, 2017, 5:44 a.m. UTC
Fixes the following sparse warning:

drivers/opp/ti-opp-supply.c:276:5: warning:
 symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/opp/ti-opp-supply.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Dec. 20, 2017, 5:42 a.m. UTC | #1
+Dave/Rafael,

On 20-12-17, 05:44, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/opp/ti-opp-supply.c:276:5: warning:
>  symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/opp/ti-opp-supply.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> index 44dae3e..370eff3 100644
> --- a/drivers/opp/ti-opp-supply.c
> +++ b/drivers/opp/ti-opp-supply.c
> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
>   *
>   * Return: If successful, 0, else appropriate error value.
>   */
> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>  {
>  	struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
>  	struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];

Maybe this should be folded to the original patch ?
Rafael J. Wysocki Dec. 21, 2017, 1:19 a.m. UTC | #2
On Wed, Dec 20, 2017 at 6:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> +Dave/Rafael,
>
> On 20-12-17, 05:44, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/opp/ti-opp-supply.c:276:5: warning:
>>  symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>>  drivers/opp/ti-opp-supply.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
>> index 44dae3e..370eff3 100644
>> --- a/drivers/opp/ti-opp-supply.c
>> +++ b/drivers/opp/ti-opp-supply.c
>> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
>>   *
>>   * Return: If successful, 0, else appropriate error value.
>>   */
>> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
>>  {
>>       struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
>>       struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
>
> Maybe this should be folded to the original patch ?

That is against the latest series from Dave, right?

I can apply it.
Viresh Kumar Dec. 21, 2017, 5:47 a.m. UTC | #3
On 21-12-17, 02:19, Rafael J. Wysocki wrote:
> On Wed, Dec 20, 2017 at 6:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > +Dave/Rafael,
> >
> > On 20-12-17, 05:44, Wei Yongjun wrote:
> >> Fixes the following sparse warning:
> >>
> >> drivers/opp/ti-opp-supply.c:276:5: warning:
> >>  symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
> >>
> >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >> ---
> >>  drivers/opp/ti-opp-supply.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> >> index 44dae3e..370eff3 100644
> >> --- a/drivers/opp/ti-opp-supply.c
> >> +++ b/drivers/opp/ti-opp-supply.c
> >> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
> >>   *
> >>   * Return: If successful, 0, else appropriate error value.
> >>   */
> >> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >>  {
> >>       struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
> >>       struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
> >
> > Maybe this should be folded to the original patch ?
> 
> That is against the latest series from Dave, right?
> 
> I can apply it.

Yes.

Patch
diff mbox

diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
index 44dae3e..370eff3 100644
--- a/drivers/opp/ti-opp-supply.c
+++ b/drivers/opp/ti-opp-supply.c
@@ -273,7 +273,7 @@  static int _opp_set_voltage(struct device *dev,
  *
  * Return: If successful, 0, else appropriate error value.
  */
-int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
+static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
 {
 	struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
 	struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];