From patchwork Sun Dec 24 17:19:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10132109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9B57B6037D for ; Sun, 24 Dec 2017 17:21:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8400A28B90 for ; Sun, 24 Dec 2017 17:21:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77EEE28D51; Sun, 24 Dec 2017 17:21:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0F84528B90 for ; Sun, 24 Dec 2017 17:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Gzd3mbYersfhK/a+5YMeOVqubepAaIcdfePvuhvUmM=; b=NiMtuvWNsbGUxS vUaJfp0IP1fo7jWUGqee0CAIq8liDoivOZAaK49M/f2f3Pus6Jmqa7Zwe7FJF18FeO02RlzaxWxEh qM862FgBgTKpaE2YJ93CQcH7973+DLorutmMteSaDp9wdOoChoi34yPy/o9hbKQcP5uR2MGfNFB/v wnEwSjRLZ0h/GoYJpEDXpd/h4fA21fDOLe5t73yqKBmF3VAgvG6zKE/L3Kg961y0FsBpV1WD/AbpE DuzS1mh06pYO5eePdd75AZ7wURnkEsHr5E8DKYGgkEgC1smdgdSQeRDxEFu/Ew6PxXszBTH8VcPyH fFa5qntHmbSqmB0ilquA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eT9xp-0007lB-4T; Sun, 24 Dec 2017 17:21:29 +0000 Received: from conssluserg-03.nifty.com ([210.131.2.82]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eT9xl-0007k3-5b for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2017 17:21:27 +0000 Received: from mail-vk0-f54.google.com (mail-vk0-f54.google.com [209.85.213.54]) (authenticated) by conssluserg-03.nifty.com with ESMTP id vBOHKei0009663 for ; Mon, 25 Dec 2017 02:20:41 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com vBOHKei0009663 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1514136041; bh=q+d8Hs17wZpPHsL8L2cSwoIpPQxsStSfrexK41538Yg=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=xCmzj4P+uwatajVDbmcSKsNyLlzmRSmJTKwr7/x4xojIOTverJHMOMsZ2WE/f3eqQ D6SPbLL+9xNLrfK81mQrolwAqOzWtCNnM36LS12jFsmrmx2TE/k0x5ew9AdY8ZhWBC kRgL/COf53eloOJcnCgN/Ner6WM5LodICARmhqAyPV0MCEqf1MDUM0xQ3IKeds29Qm pqefDg5gKiqoa052Rmd7IUcqyzvSDWU1b2pNdsbas204ul6Q4xPqBVEc28p3+wLWOE a3xGAsgHSJpWoAy15bvVtitl3LyNZPIMpY2VUOBbYJH7coCZaldTAkXAoPZaezEIem 4xhepyxyz2tHQ== X-Nifty-SrcIP: [209.85.213.54] Received: by mail-vk0-f54.google.com with SMTP id k132so10855331vke.10 for ; Sun, 24 Dec 2017 09:20:41 -0800 (PST) X-Gm-Message-State: AKGB3mJh2rCjMhy1G2SMwQi2ni941v7K3SWzxP5ie2bDoLDv1BB2aQki OY3DeVJrGETbjoYYr7+n7bWwJDERbiNpCj4bPBE= X-Google-Smtp-Source: ACJfBouAnX+MnbGGMZc4qs68ttKyjYITfV3DgrQyApa+2SEB3cETn71PH2xYOpNu1e6Wdr1satlldJo+rhtppwN1jHw= X-Received: by 10.31.6.15 with SMTP id 15mr3509734vkg.113.1514136040228; Sun, 24 Dec 2017 09:20:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.159.47.11 with HTTP; Sun, 24 Dec 2017 09:19:59 -0800 (PST) In-Reply-To: References: <1511749163-11057-1-git-send-email-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Mon, 25 Dec 2017 02:19:59 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: make ARCH_S3C24XX select USE_OF and clean-up boot/dts/Makefile To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171224_092125_461820_8E1982C3 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Arnd Bergmann , Linux Kernel Mailing List , Rob Herring , Russell King , arm-soc , Olof Johansson , linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP 2017-12-22 21:41 GMT+09:00 Krzysztof Kozlowski : > On Mon, Nov 27, 2017 at 3:19 AM, Masahiro Yamada > wrote: >> ARCH_S3C24XX is a very exceptional platform that some DT files in >> arch/arm/boot/dts/, but does not select USE_OF. > > Not entirely. The platform does select USE_OF - when MACH_S3C2416_DT > is chosen. For other boards USE_OF is not necessary because they do > not use DT. Why you need to select it for entire arch? > > Best regards, > Krzysztof > The reason is simple - to avoid compile error. If I simply drop ifeq ($(CONFIG_OF),y) but do not select ARCH_S3C24XX, s3c2410_defconfig failed to build. $ make -s ARCH=arm mrproper $ make -s ARCH=arm s3c2410_defconfig $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- dtbs ... DTC arch/arm/boot/dts/s3c2416-smdk2416.dtb /bin/sh: 1: ./scripts/dtc/dtc: not found scripts/Makefile.lib:310: recipe for target 'arch/arm/boot/dts/s3c2416-smdk2416.dtb' failed make[1]: *** [arch/arm/boot/dts/s3c2416-smdk2416.dtb] Error 127 arch/arm/Makefile:349: recipe for target 'dtbs' failed make: *** [dtbs] Error 2 Another solution would be to enable dtb by CONFIG_MACH_S3C2416_DT. If you migrate S3C24XX platform to DT, per-board CONFIG option will go away. So, I think dtb-$(CONFIG_ARCH_S3C24XX) is OK. >> All the other platforms with DT files correctly select USE_OF >> directly or indirectly (Most of them are either ARCH_MULTIPLATFORM >> or ARM_SINGLE_ARMV7M). >> >> With ARCH_S3C24XX fixed, "ifeq ($(CONFIG_OF),y)" in DT Makefile >> can be deleted. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> arch/arm/Kconfig | 1 + >> arch/arm/boot/dts/Makefile | 3 --- >> 2 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 51c8df5..5604497 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -595,6 +595,7 @@ config ARCH_S3C24XX >> select MULTI_IRQ_HANDLER >> select NEED_MACH_IO_H >> select SAMSUNG_ATAGS >> + select USE_OF >> help >> Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443 >> and S3C2450 SoCs based systems, such as the Simtec Electronics BAST >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index d0381e9..6f7f25d 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1,6 +1,4 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -ifeq ($(CONFIG_OF),y) >> - >> dtb-$(CONFIG_ARCH_ALPINE) += \ >> alpine-db.dtb >> dtb-$(CONFIG_MACH_ARTPEC6) += \ >> @@ -1104,4 +1102,3 @@ dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb >> dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \ >> aspeed-bmc-opp-romulus.dtb \ >> aspeed-ast2500-evb.dtb >> -endif >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index d0381e9..950b5dd 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -800,7 +798,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ rk3288-veyron-pinky.dtb \ rk3288-veyron-speedy.dtb \ rk3288-vyasa.dtb -dtb-$(CONFIG_ARCH_S3C24XX) += \ +dtb-$(CONFIG_MACH_S3C2416_DT) += \ s3c2416-smdk2416.dtb dtb-$(CONFIG_ARCH_S3C64XX) += \ s3c6410-mini6410.dtb \