diff mbox

[01/19] drm/i915: Delete defunct i915_gem_request_assign()

Message ID 20180102151235.3949-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson Jan. 2, 2018, 3:12 p.m. UTC
i915_gem_request_assign() is not used since commit 77f0d0e925e8
("drm/i915/execlists: Pack the count into the low bits of the
port.request"), so remove the defunct code

References: 77f0d0e925e8 ("drm/i915/execlists: Pack the count into the low bits of the port.request")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_request.h | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Rodrigo Vivi Jan. 2, 2018, 7:01 p.m. UTC | #1
On Tue, Jan 02, 2018 at 03:12:17PM +0000, Chris Wilson wrote:
> i915_gem_request_assign() is not used since commit 77f0d0e925e8
> ("drm/i915/execlists: Pack the count into the low bits of the
> port.request"), so remove the defunct code
> 
> References: 77f0d0e925e8 ("drm/i915/execlists: Pack the count into the low bits of the port.request")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> ---
>  drivers/gpu/drm/i915/i915_gem_request.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_request.h b/drivers/gpu/drm/i915/i915_gem_request.h
> index 0d6d39f19506..04ee289d6cab 100644
> --- a/drivers/gpu/drm/i915/i915_gem_request.h
> +++ b/drivers/gpu/drm/i915/i915_gem_request.h
> @@ -245,18 +245,6 @@ i915_gem_request_put(struct drm_i915_gem_request *req)
>  	dma_fence_put(&req->fence);
>  }
>  
> -static inline void i915_gem_request_assign(struct drm_i915_gem_request **pdst,
> -					   struct drm_i915_gem_request *src)
> -{
> -	if (src)
> -		i915_gem_request_get(src);
> -
> -	if (*pdst)
> -		i915_gem_request_put(*pdst);
> -
> -	*pdst = src;
> -}
> -
>  /**
>   * i915_gem_request_global_seqno - report the current global seqno
>   * @request - the request
> -- 
> 2.15.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_request.h b/drivers/gpu/drm/i915/i915_gem_request.h
index 0d6d39f19506..04ee289d6cab 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.h
+++ b/drivers/gpu/drm/i915/i915_gem_request.h
@@ -245,18 +245,6 @@  i915_gem_request_put(struct drm_i915_gem_request *req)
 	dma_fence_put(&req->fence);
 }
 
-static inline void i915_gem_request_assign(struct drm_i915_gem_request **pdst,
-					   struct drm_i915_gem_request *src)
-{
-	if (src)
-		i915_gem_request_get(src);
-
-	if (*pdst)
-		i915_gem_request_put(*pdst);
-
-	*pdst = src;
-}
-
 /**
  * i915_gem_request_global_seqno - report the current global seqno
  * @request - the request