[v4,3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface
diff mbox

Message ID 20180103091021.x2yego3wmhsq6bfx@valkosipuli.retiisi.org.uk
State New
Headers show

Commit Message

Sakari Ailus Jan. 3, 2018, 9:10 a.m. UTC
On Wed, Jan 03, 2018 at 08:47:09AM +0000, Hugues FRUCHET wrote:
> Hi Sakari,
> this is fine for me to drop those two lines so sync signals become 
> mandatory.
> Must I repost a v5 serie ?

Here's the diff:

Comments

Hugues FRUCHET Jan. 3, 2018, 9:12 a.m. UTC | #1
OK, thanks for all Sakari !

On 01/03/2018 10:10 AM, Sakari Ailus wrote:
> On Wed, Jan 03, 2018 at 08:47:09AM +0000, Hugues FRUCHET wrote:

>> Hi Sakari,

>> this is fine for me to drop those two lines so sync signals become

>> mandatory.

>> Must I repost a v5 serie ?

> 

> Here's the diff:

> 

> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt

> index e26a84646603..8e36da0d8406 100644

> --- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt

> +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt

> @@ -31,8 +31,6 @@ Endpoint node required properties for parallel connection are:

>   	     or <10> for 10 bits parallel bus

>   - data-shift: shall be set to <2> for 8 bits parallel bus

>   	      (lines 9:2 are used) or <0> for 10 bits parallel bus

> -

> -Endpoint node optional properties for parallel connection are:

>   - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.

>   - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.

>   - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock

>
Sakari Ailus Jan. 3, 2018, 9:23 a.m. UTC | #2
Hi Hugues,

On Wed, Jan 03, 2018 at 09:12:43AM +0000, Hugues FRUCHET wrote:
> OK, thanks for all Sakari !

One thing I've missed so far --- the DT binding changes should be always
cc'd to the devicetree list which I see is missing now. Could you send v5,
cc'ing at least the bindings to the devicetree list, please?

My apologies for the confusion.
Hugues FRUCHET Jan. 3, 2018, 10:02 a.m. UTC | #3
v5 sent !

On 01/03/2018 10:23 AM, Sakari Ailus wrote:
> Hi Hugues,

> 

> On Wed, Jan 03, 2018 at 09:12:43AM +0000, Hugues FRUCHET wrote:

>> OK, thanks for all Sakari !

> 

> One thing I've missed so far --- the DT binding changes should be always

> cc'd to the devicetree list which I see is missing now. Could you send v5,

> cc'ing at least the bindings to the devicetree list, please?

> 

> My apologies for the confusion.

>

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
index e26a84646603..8e36da0d8406 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
@@ -31,8 +31,6 @@  Endpoint node required properties for parallel connection are:
 	     or <10> for 10 bits parallel bus
 - data-shift: shall be set to <2> for 8 bits parallel bus
 	      (lines 9:2 are used) or <0> for 10 bits parallel bus
-
-Endpoint node optional properties for parallel connection are:
 - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
 - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
 - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock