From patchwork Wed Jan 3 22:29:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas De Marchi X-Patchwork-Id: 10143585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7C27260594 for ; Wed, 3 Jan 2018 22:29:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 698B229240 for ; Wed, 3 Jan 2018 22:29:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5CB7F293C6; Wed, 3 Jan 2018 22:29:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2288A29240 for ; Wed, 3 Jan 2018 22:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751029AbeACW3g (ORCPT ); Wed, 3 Jan 2018 17:29:36 -0500 Received: from mga06.intel.com ([134.134.136.31]:63083 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbeACW3f (ORCPT ); Wed, 3 Jan 2018 17:29:35 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 14:29:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,504,1508828400"; d="scan'208";a="192170650" Received: from ldmartin-desk.jf.intel.com ([10.24.10.79]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2018 14:29:33 -0800 From: Lucas De Marchi To: linux-modules@vger.kernel.org Cc: Yauheni Kaliuta Subject: [PATCH 5/6] testsuite: add missing error handling Date: Wed, 3 Jan 2018 14:29:23 -0800 Message-Id: <20180103222924.26347-6-lucas.demarchi@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180103222924.26347-1-lucas.demarchi@intel.com> References: <20180103222924.26347-1-lucas.demarchi@intel.com> Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP If we passed an invalid argument to a test it would segfault rather than returning an error code. --- testsuite/testsuite.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/testsuite.h b/testsuite/testsuite.h index bb0eb50..2b31483 100644 --- a/testsuite/testsuite.h +++ b/testsuite/testsuite.h @@ -151,6 +151,8 @@ int test_run(const struct test *t); arg = test_init(__start_kmod_tests, __stop_kmod_tests, argc, argv); \ if (arg == 0) \ return 0; \ + if (arg < 0) \ + return EXIT_FAILURE; \ \ if (arg < argc) { \ t = test_find(__start_kmod_tests, __stop_kmod_tests, argv[arg]); \