From patchwork Fri Jan 5 01:50:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 10145931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EF59F60329 for ; Fri, 5 Jan 2018 01:46:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22E472882E for ; Fri, 5 Jan 2018 01:46:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1524828831; Fri, 5 Jan 2018 01:46:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A03802882E for ; Fri, 5 Jan 2018 01:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PsggeETiIiepdHXThgYN8RBhke2l6+B/laLhWGnqHIs=; b=DyAVQvDiPzOmMW DXlJKIbzrfQdDhdrytL1KCHm/vs4xE0kMOxeQdjpu7sguXQg/uyqBpKpP2zfZdCE81/YC9pTOFxBR WTFKM9OQjy3AvVaYgHUzhT+17wUGPGwYFc+Gs24U7R9aFKngROPim/bcl5dFHmjd33GrIBmCGfrrY b6DvEfiU9joBnMAvpyXUPL7yxWPM7QMoQt85B5PvEgeNxUMbfig0u1RI20ioyNHWqtXKOZEBCX2r1 7LKGfdMMbSyFALTGfwFqilI7mxL+iNBDeCJeAQKCFJCf8tZI6HOI/IQ3iWeQFpQzI4FOxVHIAblUg Tl22p8xrA7/PkpPVrpiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXH4v-0004e5-6m; Fri, 05 Jan 2018 01:45:49 +0000 Received: from [45.249.212.32] (helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXH4r-0004XH-Cl; Fri, 05 Jan 2018 01:45:47 +0000 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9D8615B9AFD43; Fri, 5 Jan 2018 09:45:17 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.361.1; Fri, 5 Jan 2018 09:45:12 +0800 From: Wei Yongjun To: Neil Armstrong , Jerome Brunet , Michael Turquette , "Stephen Boyd" , Carlo Caione , Kevin Hilman Subject: [PATCH -next] clk: meson-axg: fix potential NULL dereference in axg_clkc_probe() Date: Fri, 5 Jan 2018 01:50:59 +0000 Message-ID: <1515117059-176004-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180104_174546_330892_BAD941E6 X-CRM114-Status: UNSURE ( 5.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, Wei Yongjun , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = platform_get_resource(pdev, t, n); + if (!res) + return -EINVAL; ... when != res == NULL e = devm_ioremap(e1, res->start, e2); Signed-off-by: Wei Yongjun --- drivers/clk/meson/axg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index d883bef..1294f3a 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -879,6 +879,8 @@ static int axg_clkc_probe(struct platform_device *pdev) /* Generic clocks and PLLs */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; clk_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!clk_base) { dev_err(&pdev->dev, "Unable to map clk base\n");