From patchwork Wed Jan 10 12:11:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 10154983 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF842602D8 for ; Wed, 10 Jan 2018 12:14:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C102B28511 for ; Wed, 10 Jan 2018 12:14:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B5B5928517; Wed, 10 Jan 2018 12:14:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B95B28511 for ; Wed, 10 Jan 2018 12:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964968AbeAJMOO (ORCPT ); Wed, 10 Jan 2018 07:14:14 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:43015 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbeAJMNj (ORCPT ); Wed, 10 Jan 2018 07:13:39 -0500 Received: by mail-wm0-f65.google.com with SMTP id g1so8591355wmg.2 for ; Wed, 10 Jan 2018 04:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L6hh2zUbxFH9E4x38JcNUHoFDnHjFEBUuttnSmIZZ98=; b=CZ2Ha6El0ubLi2nTeVMFVq3CIvOobsZyRpZsBPy4VeWxNlq1wmvLPQfUez8f9JNdM2 /OutBoUZxPJ30JELWyL8A1c3pplCzdhLN06dOvWYVzh9OnPhNWvkGGIRx6RqhvMLF8z1 wT1fZyF+Ru0oqcljqbRmIR1aJIi+80+R0D4TQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L6hh2zUbxFH9E4x38JcNUHoFDnHjFEBUuttnSmIZZ98=; b=j4KSC9CQVy5igxlmxg/VAnco4bFHkmUk+7CjySTRuVl/SqQTaYxc37ZCKlTINtoIca MjRoBmqoUXfE145wWsO6bxNAPT/8N49JMqX0ZMoZxM/ia8zTNMjwMrm5UhDlq0Li2SH8 l03sZ24Q0uT3l10jUE+QFJXDySCaFSNRNlvcd1g92TwVo4baNyG++RkY/SQIg2Q9nCst mD5ZvHwtq8vLyu2Tqt06ECbjJYIkLpq4fHzOSNm1SY7CcFKoPYanWx8FozqF9EgI+HB9 P+USbmWTHE1BVgMOdF3E6Hw/AxrECOQfVvdRY3UtdhP1cBixtNp4xKpECvZ3Mz1UBLkm APZg== X-Gm-Message-State: AKGB3mJONsn/rNzKQgBOyHHLwS7EJC4Wx/2PTU71ZNDQGoSEKwWpDLma K87mj8mE2q8lTASdEjLOdH4HvQ== X-Google-Smtp-Source: ACJfBou4VIo4NF1q8shKGCOcWH90RkDMTbi+sU3ch1fC3BVlAX3skEKAOdkrOIKx/15UjjvIIy5hMA== X-Received: by 10.28.234.10 with SMTP id i10mr14474863wmh.49.1515586418385; Wed, 10 Jan 2018 04:13:38 -0800 (PST) Received: from localhost.localdomain ([154.144.231.40]) by smtp.gmail.com with ESMTPSA id l72sm1261615wmi.4.2018.01.10.04.13.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jan 2018 04:13:37 -0800 (PST) From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, will.deacon@arm.com, catalin.marinas@arm.com, marc.zyngier@arm.com, mark.rutland@arm.com, dann.frazier@canonical.com, steve.capper@linaro.org, Ard Biesheuvel Subject: [PATCH 3/7] arm64/crypto: aes-neon: move literal data to .rodata section Date: Wed, 10 Jan 2018 12:11:38 +0000 Message-Id: <20180110121142.18291-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180110121142.18291-1-ard.biesheuvel@linaro.org> References: <20180110121142.18291-1-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move the S-boxes and some other literals to the .rodata section where it is safe from being exploited by speculative execution. Signed-off-by: Ard Biesheuvel --- arch/arm64/crypto/aes-neon.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/crypto/aes-neon.S b/arch/arm64/crypto/aes-neon.S index f1e3aa2732f9..1c7b45b7268e 100644 --- a/arch/arm64/crypto/aes-neon.S +++ b/arch/arm64/crypto/aes-neon.S @@ -32,10 +32,10 @@ /* preload the entire Sbox */ .macro prepare, sbox, shiftrows, temp - adr \temp, \sbox movi v12.16b, #0x1b - ldr q13, \shiftrows - ldr q14, .Lror32by8 + ldr_l q13, \shiftrows, \temp + ldr_l q14, .Lror32by8, \temp + adr_l \temp, \sbox ld1 {v16.16b-v19.16b}, [\temp], #64 ld1 {v20.16b-v23.16b}, [\temp], #64 ld1 {v24.16b-v27.16b}, [\temp], #64 @@ -272,7 +272,7 @@ #include "aes-modes.S" - .text + .section ".rodata", "a" .align 6 .LForward_Sbox: .byte 0x63, 0x7c, 0x77, 0x7b, 0xf2, 0x6b, 0x6f, 0xc5