| Message ID | 20180110215348.315-4-david@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 10.01.2018 22:53, David Hildenbrand wrote: > 160 bytes is a little small. 16k sounds better. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > s390x/flat.lds | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s390x/flat.lds b/s390x/flat.lds > index b6e2172..6bd3c23 100644 > --- a/s390x/flat.lds > +++ b/s390x/flat.lds > @@ -37,6 +37,6 @@ SECTIONS > /* > * stackptr set with initial stack frame preallocated > */ > - stackptr = . - 160; > + stackptr = . - 16k; > stacktop = .; > } Hu? Why? The "-160" is just for the first initial stack frame. The total size of the stack is handled with the ". += 64K;" right before the comment instead. Thomas
On 11.01.2018 10:19, Thomas Huth wrote: > On 10.01.2018 22:53, David Hildenbrand wrote: >> 160 bytes is a little small. 16k sounds better. >> >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- >> s390x/flat.lds | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/s390x/flat.lds b/s390x/flat.lds >> index b6e2172..6bd3c23 100644 >> --- a/s390x/flat.lds >> +++ b/s390x/flat.lds >> @@ -37,6 +37,6 @@ SECTIONS >> /* >> * stackptr set with initial stack frame preallocated >> */ >> - stackptr = . - 160; >> + stackptr = . - 16k; >> stacktop = .; >> } > > Hu? Why? > > The "-160" is just for the first initial stack frame. The total size of > the stack is handled with the ". += 64K;" right before the comment instead. Indeed, got this wrong. Dropped. (and replaced by a fix for stackptr vs. stacktop) Thanks! > > Thomas >
diff --git a/s390x/flat.lds b/s390x/flat.lds index b6e2172..6bd3c23 100644 --- a/s390x/flat.lds +++ b/s390x/flat.lds @@ -37,6 +37,6 @@ SECTIONS /* * stackptr set with initial stack frame preallocated */ - stackptr = . - 160; + stackptr = . - 16k; stacktop = .; }
160 bytes is a little small. 16k sounds better. Signed-off-by: David Hildenbrand <david@redhat.com> --- s390x/flat.lds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)