diff mbox

drm/prime: Remove duplicate forward declaration

Message ID 20180111201730.30708-1-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thierry Reding Jan. 11, 2018, 8:17 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

struct device is forward-declared twice. Remove the second instance.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/drm/drm_prime.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Chris Wilson Jan. 11, 2018, 8:59 p.m. UTC | #1 
Quoting Thierry Reding (2018-01-11 20:17:30)
> From: Thierry Reding <treding@nvidia.com>
> 
> struct device is forward-declared twice. Remove the second instance.

So good they declared it twice. Also the first one first in with the
alphabetical ordering.
 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Christian König Jan. 12, 2018, 10:28 a.m. UTC | #2 
Am 11.01.2018 um 21:17 schrieb Thierry Reding:
> From: Thierry Reding <treding@nvidia.com>
>
> struct device is forward-declared twice. Remove the second instance.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/drm/drm_prime.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index 9cd9e36f77b5..59ccab402e85 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -59,8 +59,6 @@ struct drm_device;
>   struct drm_gem_object;
>   struct drm_file;
>   
> -struct device;
> -
>   struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
>   				     struct drm_gem_object *obj,
>   				     int flags);
diff mbox

Patch

diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
index 9cd9e36f77b5..59ccab402e85 100644
--- a/include/drm/drm_prime.h
+++ b/include/drm/drm_prime.h
@@ -59,8 +59,6 @@  struct drm_device;
 struct drm_gem_object;
 struct drm_file;
 
-struct device;
-
 struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
 				     struct drm_gem_object *obj,
 				     int flags);