Message ID | 20180112220743.11513-10-mwilck@suse.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Delegated to: | Mike Snitzer |
Headers | show
Return-Path: <dm-devel-bounces@redhat.com> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A41F602A7 for <patchwork-dm-devel@patchwork.kernel.org>; Fri, 12 Jan 2018 22:09:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B83028AB3 for <patchwork-dm-devel@patchwork.kernel.org>; Fri, 12 Jan 2018 22:09:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8062D28AB6; Fri, 12 Jan 2018 22:09:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1175A28AB3 for <patchwork-dm-devel@patchwork.kernel.org>; Fri, 12 Jan 2018 22:09:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05EFFFBAF; Fri, 12 Jan 2018 22:09:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65B746046B; Fri, 12 Jan 2018 22:09:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4160618033DB; Fri, 12 Jan 2018 22:09:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w0CM8m1v024813 for <dm-devel@listman.util.phx.redhat.com>; Fri, 12 Jan 2018 17:08:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id BB8D35D9CC; Fri, 12 Jan 2018 22:08:48 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF97786B00; Fri, 12 Jan 2018 22:08:48 +0000 (UTC) Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F262F4E33E; Fri, 12 Jan 2018 22:08:46 +0000 (UTC) Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 12 Jan 2018 23:08:45 +0100 Received: from apollon.suse.de.de (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Fri, 12 Jan 2018 22:08:16 +0000 From: Martin Wilck <mwilck@suse.com> To: Christophe Varoqui <christophe.varoqui@opensvc.com>, dm-devel@redhat.com Date: Fri, 12 Jan 2018 23:07:38 +0100 Message-Id: <20180112220743.11513-10-mwilck@suse.com> In-Reply-To: <20180112220743.11513-1-mwilck@suse.com> References: <20180112220743.11513-1-mwilck@suse.com> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 207 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 12 Jan 2018 22:08:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 12 Jan 2018 22:08:47 +0000 (UTC) for IP:'195.135.221.5' DOMAIN:'smtp.nue.novell.com' HELO:'smtp.nue.novell.com' FROM:'mwilck@suse.com' RCPT:'' X-RedHat-Spam-Score: -2.301 (RCVD_IN_DNSWL_MED, SPF_PASS) 195.135.221.5 smtp.nue.novell.com 195.135.221.5 smtp.nue.novell.com <mwilck@suse.com> X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: dm-devel@redhat.com Cc: Martin Wilck <mwilck@suse.com> Subject: [dm-devel] [PATCH 09/14] libmultipath: select ALUA prioritizer for RDAC arrays only X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development <dm-devel.redhat.com> List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>, <mailto:dm-devel-request@redhat.com?subject=unsubscribe> List-Archive: <https://www.redhat.com/archives/dm-devel> List-Post: <mailto:dm-devel@redhat.com> List-Help: <mailto:dm-devel-request@redhat.com?subject=help> List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>, <mailto:dm-devel-request@redhat.com?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 12 Jan 2018 22:09:19 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c index d08954ac8464..4dba4c50beb9 100644 --- a/libmultipath/propsel.c +++ b/libmultipath/propsel.c @@ -497,7 +497,7 @@ detect_prio(struct config *conf, struct path * pp) if (pp->tpgs <= 0) return; - if (pp->tpgs == 2 && !check_rdac(pp)) { + if (pp->tpgs == 2 || !check_rdac(pp)) { if (sysfs_get_asymmetric_access_state(pp, buff, 512) >= 0) default_prio = PRIO_SYSFS; }
Since commit 7e2f46d3, multipathd with "detect_prio" setting (=default) chooses ALUA prioritizer rather than sysfs prioritizer for arrays with implicit TPGS. But the intention of that patch was to choose ALUA for NetApp E-Series (RDAC) storage arrays *only*, not for every array with implicit TPGS. Signed-off-by: Martin Wilck <mwilck@suse.com> --- libmultipath/propsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)