From patchwork Sat Jan 13 14:03:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10162231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D0CC4602D8 for ; Sat, 13 Jan 2018 14:03:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF3EF28A87 for ; Sat, 13 Jan 2018 14:03:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2E7528A97; Sat, 13 Jan 2018 14:03:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5744928A87 for ; Sat, 13 Jan 2018 14:03:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755030AbeAMODe (ORCPT ); Sat, 13 Jan 2018 09:03:34 -0500 Received: from mout.web.de ([212.227.15.14]:55626 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbeAMODd (ORCPT ); Sat, 13 Jan 2018 09:03:33 -0500 Received: from [192.168.1.3] ([77.182.233.107]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LrKEG-1ezuap3NuO-0138oq; Sat, 13 Jan 2018 15:03:27 +0100 Subject: [PATCH 1/2] nfsd: Use seq_putc() in four functions From: SF Markus Elfring To: linux-nfs@vger.kernel.org, Jeff Layton , "J. Bruce Fields" Cc: LKML , kernel-janitors@vger.kernel.org References: <43df7d8b-f37e-91ca-9c8c-96e318adeb4f@users.sourceforge.net> Message-ID: <3afb88f1-2934-f1be-067b-db43df675bd4@users.sourceforge.net> Date: Sat, 13 Jan 2018 15:03:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <43df7d8b-f37e-91ca-9c8c-96e318adeb4f@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:dmWri5K85nYbinudDRAnHWn3Ek/LcRV5HsyY8FjyseCWODQeij6 o6Vc4GF+D95ayBnoz4IJA03Td5OqYs2jMis4+qcYm26M5upqrbsd0cRGqa60F9wdZ0ZETlN ypxeQRIXuP3SXeou/dk38EGLZ7NGb/fs1Jhg5P+dS4+hsqobPt7123arpaOo9qRiHrjr+4y JPQn1LQ1c2wplU40tIp9w== X-UI-Out-Filterresults: notjunk:1; V01:K0:wKm7NdUklOU=:0F2LuthQADHVSuhiOanjLK 2et++jxLZUpbA7nbkNpGLV9XyQklaegnv8LhZ96hw6CQDo+/7tAfzUvVB8wrCm6YOOxji5GKl VFi4LTwgvJo8RKIA8Ts0FHrab7lNIf5z86iE/G+Hw/rzEtaanYNmUZUb3q22KbMoyKOryKcl9 COHQNeW5bB4GIRPhJWQoqAGIN1fGGm0NgLg8j82pV2nrv36okoxB/ZTdsc5f8HfTZO5aiPKXz XEvuPFHrYYA2YiG3ftPRhwGC/eMYzfksnihNeylIeIM9rd9+QxuoEau0l7d7yfmzs0/kuI9sM mmSqUKCr+UYD+ggm/jft+HlABT5LrYP1C0QNa5Rwh0TCVsFRMtR/DH8/QgYlNaAUIx6BIHfNe n7rqug0rV6u47oxJ2lg56ioGVJuYTL9zoqt2MxXWmADtYnNnO1mgYPy7Ggibk7DZ1/6hoI+7L X8OYESrSiYdgULxd2PwvqMOsrrDyX3YLBnYHQDxWxXOKPoLIkmkXNvFGcYgH+s3BUsSOzia3P tJ2zrBQh74fMfgBLwz4oYM/mUY404q+PiG4oz0qA/u3SrCK4aabVoOZY/osuIhDmbDSSIj3bM hLr6MlC+BWCLyqFPKACrE9k7xhaWBAESD4R1V36abCHXdjComg+wB0BCMiETs+0FeAxEhys+H RFWxF1QWDct1bE/5z25vDrhIxd5dc0Af0pop8Qe6rji90GlTw0NeZgwxLMAktZtX9WGJ0uI4k v7yfv5OWZ+wpfYIArH70XM3gmiMx//plm7dNKiN2ZxplstsvHyP+lF2HNuLzHQ9IoxU3rWdO9 GMRbvxFY/0x3iyIOXP8g6MIhHUtLozmDDlKLwMsm39olPZ/Q7I= Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 13 Jan 2018 14:20:27 +0100 Five single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfsd/export.c | 6 +++--- fs/nfsd/nfs4idmap.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index 8ceb25a10ea0..3b035a87e4c4 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -181,10 +181,10 @@ static int expkey_show(struct seq_file *m, seq_printf(m, "%08x", ek->ek_fsid[i]); if (test_bit(CACHE_VALID, &h->flags) && !test_bit(CACHE_NEGATIVE, &h->flags)) { - seq_printf(m, " "); + seq_putc(m, ' '); seq_path(m, &ek->ek_path, "\\ \t\n"); } - seq_printf(m, "\n"); + seq_putc(m, '\n'); return 0; } @@ -1123,7 +1123,7 @@ static void show_expflags(struct seq_file *m, int flags, int mask) static void show_secinfo_flags(struct seq_file *m, int flags) { - seq_printf(m, ","); + seq_putc(m, ','); show_expflags(m, flags, NFSEXP_SECINFO_FLAGS); } diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c index a5bb76593ce7..8917b5f09896 100644 --- a/fs/nfsd/nfs4idmap.c +++ b/fs/nfsd/nfs4idmap.c @@ -161,7 +161,7 @@ idtoname_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h) ent->id); if (test_bit(CACHE_VALID, &h->flags)) seq_printf(m, " %s", ent->name); - seq_printf(m, "\n"); + seq_putc(m, '\n'); return 0; } @@ -332,7 +332,7 @@ nametoid_show(struct seq_file *m, struct cache_detail *cd, struct cache_head *h) ent->name); if (test_bit(CACHE_VALID, &h->flags)) seq_printf(m, " %u", ent->id); - seq_printf(m, "\n"); + seq_putc(m, '\n'); return 0; }