| Message ID | bc0f01a84c3e984500b11ed7afae2de46eefc975.1515786971.git-series.dylan@pnwbakers.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dylan, To make it easier to spot these, do set the git subject prefix to PATCH libdrm. See autogen.sh for an example. On 12 January 2018 at 19:57, Dylan Baker <dylan@pnwbakers.com> wrote: > Copy and paste error from exynos. > > Signed-off-by: Dylan Baker <dylan.c.baker@intel.com> > --- > freedreno/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/freedreno/meson.build b/freedreno/meson.build > index b4035e1..de6a413 100644 > --- a/freedreno/meson.build > +++ b/freedreno/meson.build > @@ -64,7 +64,7 @@ pkg.generate( > name : 'libdrm_freedreno', > libraries : libdrm_freedreno, > subdirs : ['.', 'libdrm', 'freedreno'], > - version : '0.7', > + version : meson.project_version(), Ideally we'll have version file(s) to share across builds - both the shared libraries' --version-info and the pkg-config ones. Otherwise things will be out of sync far too often. But that can happen as a follow-up. The series is Reviewed-by: Emil Velikov <emil.velikov@collabora.com> -Emil
Quoting Emil Velikov (2018-01-25 02:30:10) > Hi Dylan, > > To make it easier to spot these, do set the git subject prefix to PATCH libdrm. > See autogen.sh for an example. > > On 12 January 2018 at 19:57, Dylan Baker <dylan@pnwbakers.com> wrote: > > Copy and paste error from exynos. > > > > Signed-off-by: Dylan Baker <dylan.c.baker@intel.com> > > --- > > freedreno/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/freedreno/meson.build b/freedreno/meson.build > > index b4035e1..de6a413 100644 > > --- a/freedreno/meson.build > > +++ b/freedreno/meson.build > > @@ -64,7 +64,7 @@ pkg.generate( > > name : 'libdrm_freedreno', > > libraries : libdrm_freedreno, > > subdirs : ['.', 'libdrm', 'freedreno'], > > - version : '0.7', > > + version : meson.project_version(), > > Ideally we'll have version file(s) to share across builds - both the > shared libraries' --version-info and the pkg-config ones. > Otherwise things will be out of sync far too often. But that can > happen as a follow-up. I guess thing to do for libdrm is decide how long we need both build systems. libdrm is a much simpler build than mesa so, I would hope we can iron out any remaining bugs pretty quickly. We can also cut releases whenever we want with libdrm (unlike mesa where we use a 3 month cadence). If we think that we need to have them co-exist for a long time then yes, we absolutely should do something like add a VERSION file. > The series is > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Thanks for looking at this! > > -Emil Odd, I have format.subjectPrefix set in my libdrm git repo. Maybe adding --to changes that? Dylan
diff --git a/freedreno/meson.build b/freedreno/meson.build index b4035e1..de6a413 100644 --- a/freedreno/meson.build +++ b/freedreno/meson.build @@ -64,7 +64,7 @@ pkg.generate( name : 'libdrm_freedreno', libraries : libdrm_freedreno, subdirs : ['.', 'libdrm', 'freedreno'], - version : '0.7', + version : meson.project_version(), requires_private : 'libdrm', description : 'Userspace interface to freedreno kernel DRM services', )
Copy and paste error from exynos. Signed-off-by: Dylan Baker <dylan.c.baker@intel.com> --- freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)