Message ID | 20180118150613.26140-1-jani.nikula@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Quoting Jani Nikula (2018-01-18 15:06:13) > No more sing-a-ling. > > Reported-by: Adam Jackson <ajax@redhat.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> You're-my-ding-a-ling-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Thu, Jan 18, 2018 at 05:06:13PM +0200, Jani Nikula wrote: > No more sing-a-ling. LOL, well spotted. > Reported-by: Adam Jackson <ajax@redhat.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: David Weinehall <david.weinehall@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_vbt_defs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h > index bbb173e116b3..fa4f67d3f261 100644 > --- a/drivers/gpu/drm/i915/intel_vbt_defs.h > +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h > @@ -227,7 +227,7 @@ struct bdb_general_features { > #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) > #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) > #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) > -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) > +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) > #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) > #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) > #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) > @@ -243,7 +243,7 @@ struct bdb_general_features { > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > DEVICE_TYPE_DUAL_CHANNEL | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ > @@ -253,7 +253,7 @@ struct bdb_general_features { > (DEVICE_TYPE_INTERNAL_CONNECTOR | \ > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, 2018-01-18 at 17:06 +0200, Jani Nikula wrote: > No more sing-a-ling. > > Reported-by: Adam Jackson <ajax@redhat.com> Why'd you omit the typos I reported in tools/intel_vbt_decode.c ? - ajax
On Thu, 18 Jan 2018, Adam Jackson <ajax@redhat.com> wrote: > On Thu, 2018-01-18 at 17:06 +0200, Jani Nikula wrote: >> No more sing-a-ling. >> >> Reported-by: Adam Jackson <ajax@redhat.com> > > Why'd you omit the typos I reported in tools/intel_vbt_decode.c ? This one's for the kernel. I'll apply your original patch to igt. (Sorry for the delay.) BR, Jani.
On Thu, 18 Jan 2018, David Weinehall <david.weinehall@linux.intel.com> wrote: > On Thu, Jan 18, 2018 at 05:06:13PM +0200, Jani Nikula wrote: >> No more sing-a-ling. > > LOL, well spotted. > >> Reported-by: Adam Jackson <ajax@redhat.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: David Weinehall <david.weinehall@linux.intel.com> Thanks for the reviews, pushed. BR, Jani. > >> --- >> drivers/gpu/drm/i915/intel_vbt_defs.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h >> index bbb173e116b3..fa4f67d3f261 100644 >> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h >> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h >> @@ -227,7 +227,7 @@ struct bdb_general_features { >> #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) >> #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) >> #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) >> -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) >> +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) >> #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) >> #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) >> #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) >> @@ -243,7 +243,7 @@ struct bdb_general_features { >> DEVICE_TYPE_MIPI_OUTPUT | \ >> DEVICE_TYPE_COMPOSITE_OUTPUT | \ >> DEVICE_TYPE_DUAL_CHANNEL | \ >> - DEVICE_TYPE_LVDS_SINGALING | \ >> + DEVICE_TYPE_LVDS_SIGNALING | \ >> DEVICE_TYPE_TMDS_DVI_SIGNALING | \ >> DEVICE_TYPE_VIDEO_SIGNALING | \ >> DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ >> @@ -253,7 +253,7 @@ struct bdb_general_features { >> (DEVICE_TYPE_INTERNAL_CONNECTOR | \ >> DEVICE_TYPE_MIPI_OUTPUT | \ >> DEVICE_TYPE_COMPOSITE_OUTPUT | \ >> - DEVICE_TYPE_LVDS_SINGALING | \ >> + DEVICE_TYPE_LVDS_SIGNALING | \ >> DEVICE_TYPE_TMDS_DVI_SIGNALING | \ >> DEVICE_TYPE_VIDEO_SIGNALING | \ >> DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ >> -- >> 2.11.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, 2018-01-19 at 10:17 +0200, Jani Nikula wrote: > On Thu, 18 Jan 2018, Adam Jackson <ajax@redhat.com> wrote: > > On Thu, 2018-01-18 at 17:06 +0200, Jani Nikula wrote: > > > No more sing-a-ling. > > > > > > Reported-by: Adam Jackson <ajax@redhat.com> > > > > Why'd you omit the typos I reported in tools/intel_vbt_decode.c ? > > This one's for the kernel. I'll apply your original patch to igt. (Sorry > for the delay.) Sorry about that, just saw the file name not the repo. Thanks! - ajax
diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h index bbb173e116b3..fa4f67d3f261 100644 --- a/drivers/gpu/drm/i915/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h @@ -227,7 +227,7 @@ struct bdb_general_features { #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) @@ -243,7 +243,7 @@ struct bdb_general_features { DEVICE_TYPE_MIPI_OUTPUT | \ DEVICE_TYPE_COMPOSITE_OUTPUT | \ DEVICE_TYPE_DUAL_CHANNEL | \ - DEVICE_TYPE_LVDS_SINGALING | \ + DEVICE_TYPE_LVDS_SIGNALING | \ DEVICE_TYPE_TMDS_DVI_SIGNALING | \ DEVICE_TYPE_VIDEO_SIGNALING | \ DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ @@ -253,7 +253,7 @@ struct bdb_general_features { (DEVICE_TYPE_INTERNAL_CONNECTOR | \ DEVICE_TYPE_MIPI_OUTPUT | \ DEVICE_TYPE_COMPOSITE_OUTPUT | \ - DEVICE_TYPE_LVDS_SINGALING | \ + DEVICE_TYPE_LVDS_SIGNALING | \ DEVICE_TYPE_TMDS_DVI_SIGNALING | \ DEVICE_TYPE_VIDEO_SIGNALING | \ DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
No more sing-a-ling. Reported-by: Adam Jackson <ajax@redhat.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/intel_vbt_defs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)