| Message ID | 20180119143504.16684-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2018-01-19 at 16:35 +0200, Andy Shevchenko wrote: > Instead of doing additional checks and functional calls, > just get ACPI companion device directly. > Any comments on this? The rationale is to prevent people copy'n'paste current approach instead of better one which is presented by this change. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/hid/i2c-hid/i2c-hid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c- > hid.c > index 7230243b94d3..0d3ca542e987 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -891,10 +891,10 @@ static int i2c_hid_acpi_pdata(struct i2c_client > *client, > > static void i2c_hid_acpi_fix_up_power(struct device *dev) > { > - acpi_handle handle = ACPI_HANDLE(dev); > struct acpi_device *adev; > > - if (handle && acpi_bus_get_device(handle, &adev) == 0) > + adev = ACPI_COMPANION(dev); > + if (adev) > acpi_device_fix_up_power(adev); > } >
On Fri, 19 Jan 2018, Andy Shevchenko wrote: > Instead of doing additional checks and functional calls, > just get ACPI companion device directly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/hid/i2c-hid/i2c-hid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 7230243b94d3..0d3ca542e987 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -891,10 +891,10 @@ static int i2c_hid_acpi_pdata(struct i2c_client *client, > > static void i2c_hid_acpi_fix_up_power(struct device *dev) > { > - acpi_handle handle = ACPI_HANDLE(dev); > struct acpi_device *adev; > > - if (handle && acpi_bus_get_device(handle, &adev) == 0) > + adev = ACPI_COMPANION(dev); > + if (adev) > acpi_device_fix_up_power(adev); > } Applied to for-4.17/hid-i2c. Thanks,
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 7230243b94d3..0d3ca542e987 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -891,10 +891,10 @@ static int i2c_hid_acpi_pdata(struct i2c_client *client, static void i2c_hid_acpi_fix_up_power(struct device *dev) { - acpi_handle handle = ACPI_HANDLE(dev); struct acpi_device *adev; - if (handle && acpi_bus_get_device(handle, &adev) == 0) + adev = ACPI_COMPANION(dev); + if (adev) acpi_device_fix_up_power(adev); }
Instead of doing additional checks and functional calls, just get ACPI companion device directly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/hid/i2c-hid/i2c-hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)