| Message ID | 1516376107-31410-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, On 19/01/18 16:35, Geert Uytterhoeven wrote: > - Capitalize the first word of error messages, > - Unwrap statements that fit on a single line, > - Use "VFIO" instead of "vfio" as the error message prefix. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > --- > drivers/vfio/platform/vfio_platform_common.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index 4c27f4be3c3d0385..35469af87f88678e 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -630,8 +630,7 @@ static int vfio_platform_of_probe(struct vfio_platform_device *vdev, > ret = device_property_read_string(dev, "compatible", > &vdev->compat); > if (ret) > - pr_err("VFIO: cannot retrieve compat for %s\n", > - vdev->name); > + pr_err("VFIO: Cannot retrieve compat for %s\n", vdev->name); > > return ret; > } > @@ -673,7 +672,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, > > ret = vfio_platform_get_reset(vdev); > if (ret && vdev->reset_required) { > - pr_err("vfio: no reset function found for device %s\n", > + pr_err("VFIO: No reset function found for device %s\n", > vdev->name); > return ret; > } >
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index 4c27f4be3c3d0385..35469af87f88678e 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -630,8 +630,7 @@ static int vfio_platform_of_probe(struct vfio_platform_device *vdev, ret = device_property_read_string(dev, "compatible", &vdev->compat); if (ret) - pr_err("VFIO: cannot retrieve compat for %s\n", - vdev->name); + pr_err("VFIO: Cannot retrieve compat for %s\n", vdev->name); return ret; } @@ -673,7 +672,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, ret = vfio_platform_get_reset(vdev); if (ret && vdev->reset_required) { - pr_err("vfio: no reset function found for device %s\n", + pr_err("VFIO: No reset function found for device %s\n", vdev->name); return ret; }
- Capitalize the first word of error messages, - Unwrap statements that fit on a single line, - Use "VFIO" instead of "vfio" as the error message prefix. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/vfio/platform/vfio_platform_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)