@@ -399,6 +399,7 @@ xfs_log_regrant(
return 0;
trace_xfs_log_regrant(log, tic);
+ XFS_STATS_INC(mp, xs_regrant_logspace);
error = xlog_grant_head_check(log, &log->l_write_head, tic,
&need_bytes);
@@ -99,7 +99,7 @@ struct __xfsstats {
uint32_t xs_log_noiclogs;
uint32_t xs_log_force;
uint32_t xs_log_force_sleep;
-# define XFSSTAT_END_TAIL_PUSHING (XFSSTAT_END_LOG_OPS+10)
+# define XFSSTAT_END_TAIL_PUSHING (XFSSTAT_END_LOG_OPS+11)
uint32_t xs_try_logspace;
uint32_t xs_sleep_logspace;
uint32_t xs_push_ail;
@@ -110,6 +110,7 @@ struct __xfsstats {
uint32_t xs_push_ail_flushing;
uint32_t xs_push_ail_restarts;
uint32_t xs_push_ail_flush;
+ uint32_t xs_regrant_logspace;
# define XFSSTAT_END_WRITE_CONVERT (XFSSTAT_END_TAIL_PUSHING+2)
uint32_t xs_xstrat_quick;
uint32_t xs_xstrat_split;
Add a runtime stat to track the number of regrants that occur that were not satisfied by the initial transaction reservation (i.e., ->tr_logcount), regardless of whether blocking for reservation was required. The purpose of this stat is to help shed some light on how certain transaction changes may affect runtime behavior. For example, deferring AGFL block frees can cause an additional transaction rolls in cases where it is enabled. The regrant stat helps track how this behavior affects workloads and to consider whether to update transaction reservation counts. Update the tail pushing section of the stats structure with the new field since it already includes a couple other logspace-related stats. Add the new stat at the end to minimize compatibility issues with any stats-parsing scripts, etc. that may exist out in the wild. Signed-off-by: Brian Foster <bfoster@redhat.com> --- fs/xfs/xfs_log.c | 1 + fs/xfs/xfs_stats.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)