| Message ID | 20180125142655.GA23885@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 25, 2018 at 05:26:55PM +0300, Dan Carpenter wrote: > The parentheses are in the wrong place here so we pass the bits per > pixel as zero. > > Fixes: abbee6238775 ("drm/mgag200: Added resolution and bandwidth limits for various G200e products.") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Static analysis. Not tested. Looks reasonable. Thanks for the patch, applied. -Daniel > > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c > index 68e5d9c94475..fb50a9ddaae8 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1620,8 +1620,8 @@ static int mga_vga_mode_valid(struct drm_connector *connector, > return MODE_VIRTUAL_X; > if (mode->vdisplay > 1024) > return MODE_VIRTUAL_Y; > - if (mga_vga_calculate_mode_bandwidth(mode, > - bpp > (31877 * 1024))) > + if (mga_vga_calculate_mode_bandwidth(mode, bpp) > > + (31877 * 1024)) > return MODE_BANDWIDTH; > } else if (mdev->type == G200_EV && > (mga_vga_calculate_mode_bandwidth(mode, bpp)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 68e5d9c94475..fb50a9ddaae8 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1620,8 +1620,8 @@ static int mga_vga_mode_valid(struct drm_connector *connector, return MODE_VIRTUAL_X; if (mode->vdisplay > 1024) return MODE_VIRTUAL_Y; - if (mga_vga_calculate_mode_bandwidth(mode, - bpp > (31877 * 1024))) + if (mga_vga_calculate_mode_bandwidth(mode, bpp) > + (31877 * 1024)) return MODE_BANDWIDTH; } else if (mdev->type == G200_EV && (mga_vga_calculate_mode_bandwidth(mode, bpp)
The parentheses are in the wrong place here so we pass the bits per pixel as zero. Fixes: abbee6238775 ("drm/mgag200: Added resolution and bandwidth limits for various G200e products.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Static analysis. Not tested.