| Message ID | 20180129113323.18961-5-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote: > '__packed' is not used anywhere, remove it. Umm, this is not a variable, this is type annotation meaning that the structure is packed. Still not needed, as we are not using anything but u8 data elements, but justification is completely wrong. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/input/touchscreen/mms114.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index fb4435ae506b..11dba8bb48e3 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -78,7 +78,7 @@ struct mms114_touch { > u8 width; > u8 strength; > u8 reserved[2]; > -} __packed; > +}; > > static void mms114_process_mt(struct mms114_data *data, struct mms114_touch *touch) > { > -- > 2.15.1 >
Hi Dmitry, On Mon, Jan 29, 2018 at 10:43:09AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote: > > '__packed' is not used anywhere, remove it. > > Umm, this is not a variable, this is type annotation meaning that the > structure is packed. Still not needed, as we are not using anything but > u8 data elements, but justification is completely wrong. Oh dammit! :) of course! The original idea was the alignment of the structure, but I must have got confused while re-editing all the commits. Sorry, I'll fix it. Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index fb4435ae506b..11dba8bb48e3 100644 --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -78,7 +78,7 @@ struct mms114_touch { u8 width; u8 strength; u8 reserved[2]; -} __packed; +}; static void mms114_process_mt(struct mms114_data *data, struct mms114_touch *touch) {
'__packed' is not used anywhere, remove it. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)