[PULL,03/28] KVM: arm/arm64: Remove redundant preemptible checks
diff mbox

Message ID 20180131093507.22219-4-christoffer.dall@linaro.org
State New
Headers show

Commit Message

Christoffer Dall Jan. 31, 2018, 9:34 a.m. UTC
The __this_cpu_read() and __this_cpu_write() functions already implement
checks for the required preemption levels when using
CONFIG_DEBUG_PREEMPT which gives you nice error messages and such.
Therefore there is no need to explicitly check this using a BUG_ON() in
the code (which we don't do for other uses of per cpu variables either).

Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
 virt/kvm/arm/arm.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox

diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
index 6b60c98a6e22..3610e132df8b 100644
--- a/virt/kvm/arm/arm.c
+++ b/virt/kvm/arm/arm.c
@@ -71,7 +71,6 @@  static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled);
 static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
-	BUG_ON(preemptible());
 	__this_cpu_write(kvm_arm_running_vcpu, vcpu);
@@ -81,7 +80,6 @@  static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
 struct kvm_vcpu *kvm_arm_get_running_vcpu(void)
-	BUG_ON(preemptible());
 	return __this_cpu_read(kvm_arm_running_vcpu);