| Message ID | 20180131093434.20050-11-ulfalizer@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > Blank help texts are probably either a typo, a Kconfig misunderstanding, > or some kind of half-committing to adding a help text (in which case a > TODO comment would be clearer, if the help text really can't be added > right away). > > Best to remove them, IMO. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- FYI. I picked up this patch to kbuild because I need this to suppress warning messages introduced by 11/11. I am planning to send a PR for this series next week. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2018-01-31 at 10:34 +0100, Ulf Magnusson wrote: > Blank help texts are probably either a typo, a Kconfig > misunderstanding, > or some kind of half-committing to adding a help text (in which case > a > TODO comment would be clearer, if the help text really can't be added > right away). > > Best to remove them, IMO. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > arch/nios2/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig > index 60fae03dac79..3d4ec88f1db1 100644 > --- a/arch/nios2/Kconfig > +++ b/arch/nios2/Kconfig > @@ -152,7 +152,6 @@ menu "Advanced setup" > > config ADVANCED_OPTIONS > bool "Prompt for advanced kernel configuration options" > - help > > comment "Default settings for advanced configuration options are > used" > depends on !ADVANCED_OPTIONS > -- > 2.14.1 > Acked-by: Ley Foon Tan <ley.foon.tan@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index 60fae03dac79..3d4ec88f1db1 100644 --- a/arch/nios2/Kconfig +++ b/arch/nios2/Kconfig @@ -152,7 +152,6 @@ menu "Advanced setup" config ADVANCED_OPTIONS bool "Prompt for advanced kernel configuration options" - help comment "Default settings for advanced configuration options are used" depends on !ADVANCED_OPTIONS
Blank help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to remove them, IMO. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- arch/nios2/Kconfig | 1 - 1 file changed, 1 deletion(-)