diff mbox

[1/2] DT: arm: shmobile: document R8A77980 SoC bindings

Message ID d238e77a-e304-1fca-7ca6-bb99f6e55a68@cogentembedded.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Sergei Shtylyov Jan. 31, 2018, 7:56 p.m. UTC
Document the R-Car V3H (R8A77980) SoC device tree bindings.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 Documentation/devicetree/bindings/arm/shmobile.txt |    2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven Feb. 1, 2018, 8:01 p.m. UTC | #1
On Wed, Jan 31, 2018 at 8:56 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Document the R-Car V3H (R8A77980) SoC device tree bindings.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Some people may complain about the subject prefix, though.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman Feb. 2, 2018, 8:51 a.m. UTC | #2
On Thu, Feb 01, 2018 at 09:01:54PM +0100, Geert Uytterhoeven wrote:
> On Wed, Jan 31, 2018 at 8:56 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Document the R-Car V3H (R8A77980) SoC device tree bindings.
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Some people may complain about the subject prefix, though.

I'm a bit unsure about what to do about prefixes for that file.
I've gone with the following which seems sensible to me.

arm64: renesas: document R8A77980 SoC bindings
Rob Herring (Arm) Feb. 5, 2018, 6:08 a.m. UTC | #3
On Fri, Feb 02, 2018 at 09:51:01AM +0100, Simon Horman wrote:
> On Thu, Feb 01, 2018 at 09:01:54PM +0100, Geert Uytterhoeven wrote:
> > On Wed, Jan 31, 2018 at 8:56 PM, Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > > Document the R-Car V3H (R8A77980) SoC device tree bindings.
> > >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > Some people may complain about the subject prefix, though.

By "some people", Geert means me. :)

> 
> I'm a bit unsure about what to do about prefixes for that file.
> I've gone with the following which seems sensible to me.

This should make it somewhat clear:

git log --oneline -- Documentation/devicetree/bindings/arm/

> 
> arm64: renesas: document R8A77980 SoC bindings 

"dt-bindings: arm: ..." or  "dt-bindings: shmobile: ".

But then I don't make folks respin just for that, so

Reviewed-by: Rob Herring <robh@kernel.org>

Rob
Simon Horman Feb. 5, 2018, 8:24 a.m. UTC | #4
On Mon, Feb 05, 2018 at 12:08:41AM -0600, Rob Herring wrote:
> On Fri, Feb 02, 2018 at 09:51:01AM +0100, Simon Horman wrote:
> > On Thu, Feb 01, 2018 at 09:01:54PM +0100, Geert Uytterhoeven wrote:
> > > On Wed, Jan 31, 2018 at 8:56 PM, Sergei Shtylyov
> > > <sergei.shtylyov@cogentembedded.com> wrote:
> > > > Document the R-Car V3H (R8A77980) SoC device tree bindings.
> > > >
> > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > 
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > 
> > > Some people may complain about the subject prefix, though.
> 
> By "some people", Geert means me. :)
> 
> > 
> > I'm a bit unsure about what to do about prefixes for that file.
> > I've gone with the following which seems sensible to me.
> 
> This should make it somewhat clear:
> 
> git log --oneline -- Documentation/devicetree/bindings/arm/
> 
> > 
> > arm64: renesas: document R8A77980 SoC bindings 
> 
> "dt-bindings: arm: ..." or  "dt-bindings: shmobile: ".

Thanks, I've updated the subject to the following when adding
your tag.

dt-bindings: arm: document R8A77980 SoC bindings

> But then I don't make folks respin just for that, so
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox

Patch

Index: renesas/Documentation/devicetree/bindings/arm/shmobile.txt
===================================================================
--- renesas.orig/Documentation/devicetree/bindings/arm/shmobile.txt
+++ renesas/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -41,6 +41,8 @@  SoCs:
     compatible = "renesas,r8a7796"
   - R-Car V3M (R8A77970)
     compatible = "renesas,r8a77970"
+  - R-Car V3H (R8A77980)
+    compatible = "renesas,r8a77980"
   - R-Car D3 (R8A77995)
     compatible = "renesas,r8a77995"