| Message ID | 20180205012146.23981-11-ulfalizer@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off > GENERIC_IO option"), but HAS_IOMEM still selects it. > > Remove the select of GENERIC_IO from HAS_IOMEM. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > lib/Kconfig | 1 - > 1 file changed, 1 deletion(-) There was another fix[1] for this but it seems to have gotten lost. Acked-by: Rob Herring <robh@kernel.org> Rob [1] https://lkml.org/lkml/2018/1/17/924 -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/02/18 01:21, Ulf Magnusson wrote: > GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off > GENERIC_IO option"), but HAS_IOMEM still selects it. > > Remove the select of GENERIC_IO from HAS_IOMEM. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. Since I also stumbled over this and tried to fix it, Acked-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > lib/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index e96089499371..8ce8bcad6eff 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -396,7 +396,6 @@ config ASSOCIATIVE_ARRAY > config HAS_IOMEM > bool > depends on !NO_IOMEM > - select GENERIC_IO > default y > > config HAS_IOPORT_MAP > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off > GENERIC_IO option"), but HAS_IOMEM still selects it. > > Remove the select of GENERIC_IO from HAS_IOMEM. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > lib/Kconfig | 1 - > 1 file changed, 1 deletion(-) Who do you intend to apply this because people keep sending the same fix? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 19, 2018 at 4:48 PM, Rob Herring <robh@kernel.org> wrote: > On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off >> GENERIC_IO option"), but HAS_IOMEM still selects it. >> >> Remove the select of GENERIC_IO from HAS_IOMEM. >> >> Discovered with the >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> --- >> lib/Kconfig | 1 - >> 1 file changed, 1 deletion(-) > > Who do you intend to apply this because people keep sending the same fix? > > Rob I didn't have a particular tree in mind. I imagined people would pick up patches into the trees where they make the most sense. I just turned it into a patchset to keep track of it easier myself. Looks like that might have caused some confusion in retrospect. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/Kconfig b/lib/Kconfig index e96089499371..8ce8bcad6eff 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -396,7 +396,6 @@ config ASSOCIATIVE_ARRAY config HAS_IOMEM bool depends on !NO_IOMEM - select GENERIC_IO default y config HAS_IOPORT_MAP
GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off GENERIC_IO option"), but HAS_IOMEM still selects it. Remove the select of GENERIC_IO from HAS_IOMEM. Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- lib/Kconfig | 1 - 1 file changed, 1 deletion(-)