| Message ID | 20180205012146.23981-17-ulfalizer@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 > driver"). > > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > drivers/auxdisplay/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 2c2ed9cf8796..3cba78d36eec 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -137,7 +137,7 @@ config CFAG12864B_RATE > config IMG_ASCII_LCD > tristate "Imagination Technologies ASCII LCD Display" > depends on HAS_IOMEM > - default y if MIPS_MALTA || MIPS_SEAD3 > + default y if MIPS_MALTA > select SYSCON > help > Enable this to support the simple ASCII LCD displays found on > -- > 2.14.1 > The SYSCON symbol selected here is also globally undefined. Maybe MFD_SYSCON was intended. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/04/2018 05:58 PM, Ulf Magnusson wrote: > On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: >> The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 >> driver"). >> >> Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. >> >> Discovered with the >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py >> script. >> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> >> --- >> drivers/auxdisplay/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig >> index 2c2ed9cf8796..3cba78d36eec 100644 >> --- a/drivers/auxdisplay/Kconfig >> +++ b/drivers/auxdisplay/Kconfig >> @@ -137,7 +137,7 @@ config CFAG12864B_RATE >> config IMG_ASCII_LCD >> tristate "Imagination Technologies ASCII LCD Display" >> depends on HAS_IOMEM >> - default y if MIPS_MALTA || MIPS_SEAD3 >> + default y if MIPS_MALTA >> select SYSCON >> help >> Enable this to support the simple ASCII LCD displays found on >> -- >> 2.14.1 >> > > The SYSCON symbol selected here is also globally undefined. Maybe > MFD_SYSCON was intended. Yes. from 2018-JAN-18, Corentin Labbe: https://marc.info/?l=linux-kernel&m=151630656607526&w=2
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 > driver"). Commit 64601cb1343f did not remove the MIPS_SEAD3 symbol, it seemed to a few months before, in 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board"). Can you please amend the description? Thanks! Miguel > > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > drivers/auxdisplay/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 2c2ed9cf8796..3cba78d36eec 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -137,7 +137,7 @@ config CFAG12864B_RATE > config IMG_ASCII_LCD > tristate "Imagination Technologies ASCII LCD Display" > depends on HAS_IOMEM > - default y if MIPS_MALTA || MIPS_SEAD3 > + default y if MIPS_MALTA > select SYSCON > help > Enable this to support the simple ASCII LCD displays found on > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5 February 2018 at 01:21, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 > driver"). > > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. Its not a dependency, just a default (presumably so that existing kernel configs get updated automatically). Note that sead3 now uses MIPS_GENERIC (or more specifically CONFIG_LEGACY_BOARD_SEAD3), but this driver is enabled in the config snippets, e.g.: arch/mips/configs/generic/board-sead-3.config arch/mips/configs/generic/board-boston.config so indeed there is no real need to replace MIPS_SEAD3 with anything here. Cheers James > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > drivers/auxdisplay/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 2c2ed9cf8796..3cba78d36eec 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -137,7 +137,7 @@ config CFAG12864B_RATE > config IMG_ASCII_LCD > tristate "Imagination Technologies ASCII LCD Display" > depends on HAS_IOMEM > - default y if MIPS_MALTA || MIPS_SEAD3 > + default y if MIPS_MALTA > select SYSCON > help > Enable this to support the simple ASCII LCD displays found on > -- > 2.14.1 >
On Thu, Feb 08, 2018 at 05:35:30PM +0000, James Hogan wrote: > On 5 February 2018 at 01:21, Ulf Magnusson <ulfalizer@gmail.com> wrote: > > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 > > driver"). > > > > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. > > Its not a dependency, just a default (presumably so that existing > kernel configs get updated automatically). Note that it appears in the default's condition rather than as part of the default value. Undefined Kconfig symbols always evaluate to n in a tristate state, regardless of whether they're given a user value in a .config file or not, so this is a no-op as far as Kconfig in concerned. The motivation in the original commit message was a bit lackluster though. I've submitted a v2. > > Note that sead3 now uses MIPS_GENERIC (or more specifically > CONFIG_LEGACY_BOARD_SEAD3), but this driver is enabled in the config > snippets, e.g.: > arch/mips/configs/generic/board-sead-3.config > arch/mips/configs/generic/board-boston.config > > so indeed there is no real need to replace MIPS_SEAD3 with anything here. > > Cheers > James > > > > > Discovered with the > > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > > script. > > > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > > --- > > drivers/auxdisplay/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > > index 2c2ed9cf8796..3cba78d36eec 100644 > > --- a/drivers/auxdisplay/Kconfig > > +++ b/drivers/auxdisplay/Kconfig > > @@ -137,7 +137,7 @@ config CFAG12864B_RATE > > config IMG_ASCII_LCD > > tristate "Imagination Technologies ASCII LCD Display" > > depends on HAS_IOMEM > > - default y if MIPS_MALTA || MIPS_SEAD3 > > + default y if MIPS_MALTA > > select SYSCON > > help > > Enable this to support the simple ASCII LCD displays found on > > -- > > 2.14.1 > > > > > > -- > James Hogan Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index 2c2ed9cf8796..3cba78d36eec 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -137,7 +137,7 @@ config CFAG12864B_RATE config IMG_ASCII_LCD tristate "Imagination Technologies ASCII LCD Display" depends on HAS_IOMEM - default y if MIPS_MALTA || MIPS_SEAD3 + default y if MIPS_MALTA select SYSCON help Enable this to support the simple ASCII LCD displays found on
The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 driver"). Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD. Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- drivers/auxdisplay/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)