[1/2] arm64: dts: fsl: imx8mq: add watchdog devices
diff mbox

Message ID 4c7c9104ca95419d22b8df19a69819e194dd3488.1517816731.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach Feb. 5, 2018, 7:45 a.m. UTC
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

Comments

Fabio Estevam Feb. 5, 2018, 10:27 a.m. UTC | #1
Hi Baruch,

On Mon, Feb 5, 2018 at 5:45 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 50ed302d299a..740457e2a0bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -250,6 +250,30 @@
>                                               "clk_ext1", "clk_ext2",
>                                               "clk_ext3", "clk_ext4";
>                         };
> +
> +                       wdog1: wdog@30280000 {
> +                               compatible = "fsl,imx21-wdt";

Please use:

compatible = "fsl,imx8mq-wdt", "fsl,imx21-wdt"; instead.

This is the preferred way as it allows us to apply specific mx8qm
fixes if needed.

Thanks
Lucas Stach Feb. 5, 2018, 11:21 a.m. UTC | #2
Am Montag, den 05.02.2018, 09:45 +0200 schrieb Baruch Siach:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 50ed302d299a..740457e2a0bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -250,6 +250,30 @@
> >  				              "clk_ext1", "clk_ext2",
> >  				              "clk_ext3", "clk_ext4";
> >  			};
> +
> +			wdog1: wdog@30280000 {

watchdog@, please.

Otherwise looks good to me, so with this fixed:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de

> +				compatible = "fsl,imx21-wdt";
> > +				reg = <0x30280000 0x10000>;
> > +				interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> > +				clocks = <&clk IMX8MQ_CLK_WDOG1_ROOT>;
> > +				status = "disabled";
> > +			};
> +
> > > +			wdog2: wdog@30290000 {
> > +				compatible = "fsl,imx21-wdt";
> > +				reg = <0x30290000 0x10000>;
> > +				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> > +				clocks = <&clk IMX8MQ_CLK_WDOG2_ROOT>;
> > +				status = "disabled";
> > +			};
> +
> > > +			wdog3: wdog@302a0000 {
> > +				compatible = "fsl,imx21-wdt";
> > +				reg = <0x302a0000 0x10000>;
> > +				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> > +				clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
> > +				status = "disabled";
> > +			};
> >  		};
>  
> >  		bus@30400000 { /* AIPS2 */

Patch
diff mbox

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 50ed302d299a..740457e2a0bf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -250,6 +250,30 @@ 
 				              "clk_ext1", "clk_ext2",
 				              "clk_ext3", "clk_ext4";
 			};
+
+			wdog1: wdog@30280000 {
+				compatible = "fsl,imx21-wdt";
+				reg = <0x30280000 0x10000>;
+				interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_WDOG1_ROOT>;
+				status = "disabled";
+			};
+
+			wdog2: wdog@30290000 {
+				compatible = "fsl,imx21-wdt";
+				reg = <0x30290000 0x10000>;
+				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_WDOG2_ROOT>;
+				status = "disabled";
+			};
+
+			wdog3: wdog@302a0000 {
+				compatible = "fsl,imx21-wdt";
+				reg = <0x302a0000 0x10000>;
+				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
+				status = "disabled";
+			};
 		};
 
 		bus@30400000 { /* AIPS2 */