Patchwork crypto: ccp - Make function ccp_get_dma_chan_attr static

login
register
mail settings
Submitter Colin Ian King
Date Feb. 6, 2018, 11:20 p.m.
Message ID <20180206232001.14102-1-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/10204307/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Colin Ian King - Feb. 6, 2018, 11:20 p.m.
From: Colin Ian King <colin.king@canonical.com>

Function ccp_get_dma_chan_attr is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
drivers/crypto/ccp/ccp-dmaengine.c:41:14: warning: symbol
'ccp_get_dma_chan_attr' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Herbert Xu - Feb. 15, 2018, 3:52 p.m.
On Tue, Feb 06, 2018 at 11:20:01PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function ccp_get_dma_chan_attr is local to the source and does not
> need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/crypto/ccp/ccp-dmaengine.c:41:14: warning: symbol
> 'ccp_get_dma_chan_attr' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.

Patch

diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
index 8b9da58459df..67155cb21636 100644
--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -38,7 +38,7 @@  static unsigned int dma_chan_attr = CCP_DMA_DFLT;
 module_param(dma_chan_attr, uint, 0444);
 MODULE_PARM_DESC(dma_chan_attr, "Set DMA channel visibility: 0 (default) = device defaults, 1 = make private, 2 = make public");
 
-unsigned int ccp_get_dma_chan_attr(struct ccp_device *ccp)
+static unsigned int ccp_get_dma_chan_attr(struct ccp_device *ccp)
 {
 	switch (dma_chan_attr) {
 	case CCP_DMA_DFLT: