[v2,2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog
diff mbox

Message ID ae093f95bae9f4f92c5bbc6fc06cdeb8cfc1d1e1.1518016370.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach Feb. 7, 2018, 3:12 p.m. UTC
The external nWDOG signal connects to the EVK board reset circuit.

Tested on the i.MX8MQ EVK rev B3.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2:
  * Rename the fsl,pins to pinmux
  * Drop input-schmitt-enable
---
 arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Fabio Estevam Feb. 7, 2018, 3:43 p.m. UTC | #1
On Wed, Feb 7, 2018 at 1:12 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> The external nWDOG signal connects to the EVK board reset circuit.
>
> Tested on the i.MX8MQ EVK rev B3.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

There is an ongoing discussion whether we are going to adopt this
generic pinctrl scheme or the old i.MX pinctrl scheme on i.MX8MQ.

Anyway this patch looks good:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Lucas Stach Feb. 7, 2018, 3:49 p.m. UTC | #2
Am Mittwoch, den 07.02.2018, 13:43 -0200 schrieb Fabio Estevam:
> On Wed, Feb 7, 2018 at 1:12 PM, Baruch Siach <baruch@tkos.co.il>
> wrote:
> > The external nWDOG signal connects to the EVK board reset circuit.
> > 
> > Tested on the i.MX8MQ EVK rev B3.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> There is an ongoing discussion whether we are going to adopt this
> generic pinctrl scheme or the old i.MX pinctrl scheme on i.MX8MQ.

Yep, ignoring this discussion, patch looks good. I've just tested this
on my MX8_EVK A1 board and it seems to work fine.

Tested-by: Lucas Stach <l.stach@pengutronix.de>

Patch
diff mbox

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index c0e5ee5d6243..15be7ee9c9e4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -170,6 +170,13 @@ 
 	status = "okay";
 };
 
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl_fec1_mdc: fec1mdcgrp {
 		pinmux = <MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC>;
@@ -402,4 +409,11 @@ 
 		bias-pull-up;
 		input-schmitt-enable;
 	};
+
+	pinctrl_wdog: wdoggrp {
+		pinmux = <MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B>;
+		drive-strength = <6>;
+		slew-rate = <0>;
+		bias-pull-up;
+	};
 };