| Message ID | 20180209130755.11893-1-david.weinehall@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 09, 2018 at 03:07:55PM +0200, David Weinehall wrote: > While the comment singles out Port A or B, the code says Port A or *D*. > Looking at the history it seems that the comment was added after the code, > so it seems likely that the code is correct, not the comment. > > CC: Jani Nikula <jani.nikula@intel.com> > CC: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com> Matches my read of BSpec. Reviewed-by: James Ausmus <james.ausmus@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index f10a14330e7c..21d526bd4df6 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp) > if (IS_CNL_WITH_PORT_F(dev_priv)) > return 810000; > > - /* For other SKUs, max rate on ports A and B is 5.4G */ > + /* For other SKUs, max rate on ports A and D is 5.4G */ > if (port == PORT_A || port == PORT_D) > return 540000; > > -- > 2.16.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Feb 09, 2018 at 11:32:59PM +0000, James Ausmus wrote: > On Fri, Feb 09, 2018 at 03:07:55PM +0200, David Weinehall wrote: > > While the comment singles out Port A or B, the code says Port A or *D*. > > Looking at the history it seems that the comment was added after the code, > > so it seems likely that the code is correct, not the comment. > > > > CC: Jani Nikula <jani.nikula@intel.com> > > CC: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com> > > Matches my read of BSpec. > > Reviewed-by: James Ausmus <james.ausmus@intel.com> Thanks for patch and review. merged to dinq. > > > --- > > drivers/gpu/drm/i915/intel_dp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > index f10a14330e7c..21d526bd4df6 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp) > > if (IS_CNL_WITH_PORT_F(dev_priv)) > > return 810000; > > > > - /* For other SKUs, max rate on ports A and B is 5.4G */ > > + /* For other SKUs, max rate on ports A and D is 5.4G */ > > if (port == PORT_A || port == PORT_D) > > return 540000; > > > > -- > > 2.16.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f10a14330e7c..21d526bd4df6 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp) if (IS_CNL_WITH_PORT_F(dev_priv)) return 810000; - /* For other SKUs, max rate on ports A and B is 5.4G */ + /* For other SKUs, max rate on ports A and D is 5.4G */ if (port == PORT_A || port == PORT_D) return 540000;
While the comment singles out Port A or B, the code says Port A or *D*. Looking at the history it seems that the comment was added after the code, so it seems likely that the code is correct, not the comment. CC: Jani Nikula <jani.nikula@intel.com> CC: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: David Weinehall <david.weinehall@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)