| Message ID | 20180209155042.28461-2-steved@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/09/2018 10:50 AM, Steve Dickson wrote: > The xdr c-files, generated from .x by rpcgen, in both > libnsm.a and libexport.a libraries cause the > following warnings: > > mount_xdr.c:43:20: warning: unused variable 'buf' [-Wunused-variable] > sm_inter_xdr.c:37:20: warning: unused variable 'buf' [-Wunused-variable] > sm_inter_xdr.c:51:6: warning: unused variable 'i' [-Wunused-variable] > > These warnings are caused by rpcgen trying in inline > the xdr routines. It turns out no inlining was happening, > except for one routine. So turning off inlining eliminated > these warnings. > > This patch also eliminates a Werror missing-prototypes in sm_inter.h > > Signed-off-by: Steve Dickson <steved@redhat.com> Committed... steved. > --- > support/export/Makefile.am | 2 +- > support/nsm/Makefile.am | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/support/export/Makefile.am b/support/export/Makefile.am > index be3de69..13f7a49 100644 > --- a/support/export/Makefile.am > +++ b/support/export/Makefile.am > @@ -35,7 +35,7 @@ $(GENFILES_CLNT): %_clnt.c: %.x $(RPCGEN) > > $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) > test -f $@ && rm -rf $@ || true > - $(RPCGEN) -c -o $@ $< > + $(RPCGEN) -c -i 0 -o $@ $< > > $(GENFILES_H): %.h: %.x $(RPCGEN) > test -f $@ && rm -rf $@ || true > diff --git a/support/nsm/Makefile.am b/support/nsm/Makefile.am > index 2038e68..8f5874e 100644 > --- a/support/nsm/Makefile.am > +++ b/support/nsm/Makefile.am > @@ -32,11 +32,12 @@ $(GENFILES_SVC): %_svc.c: %.x $(RPCGEN) > > $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) > test -f $@ && rm -rf $@ || true > - $(RPCGEN) -c -o $@ $< > + $(RPCGEN) -c -i 0 -o $@ $< > > $(GENFILES_H): %.h: %.x $(RPCGEN) > test -f $@ && rm -rf $@ || true > $(RPCGEN) -h -o $@ $< > + echo "void sm_prog_1(struct svc_req *, SVCXPRT *);" >> $@ > rm -f $(top_builddir)/support/include/sm_inter.h > $(LN_S) ../nsm/sm_inter.h $(top_builddir)/support/include/sm_inter.h > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/support/export/Makefile.am b/support/export/Makefile.am index be3de69..13f7a49 100644 --- a/support/export/Makefile.am +++ b/support/export/Makefile.am @@ -35,7 +35,7 @@ $(GENFILES_CLNT): %_clnt.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true diff --git a/support/nsm/Makefile.am b/support/nsm/Makefile.am index 2038e68..8f5874e 100644 --- a/support/nsm/Makefile.am +++ b/support/nsm/Makefile.am @@ -32,11 +32,12 @@ $(GENFILES_SVC): %_svc.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true $(RPCGEN) -h -o $@ $< + echo "void sm_prog_1(struct svc_req *, SVCXPRT *);" >> $@ rm -f $(top_builddir)/support/include/sm_inter.h $(LN_S) ../nsm/sm_inter.h $(top_builddir)/support/include/sm_inter.h
The xdr c-files, generated from .x by rpcgen, in both libnsm.a and libexport.a libraries cause the following warnings: mount_xdr.c:43:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:37:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:51:6: warning: unused variable 'i' [-Wunused-variable] These warnings are caused by rpcgen trying in inline the xdr routines. It turns out no inlining was happening, except for one routine. So turning off inlining eliminated these warnings. This patch also eliminates a Werror missing-prototypes in sm_inter.h Signed-off-by: Steve Dickson <steved@redhat.com> --- support/export/Makefile.am | 2 +- support/nsm/Makefile.am | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)