diff mbox

[06/43] misc/mei/hdcp: Add KBuild for mei hdcp driver

Message ID 1518617638-21684-7-git-send-email-ramalingam.c@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ramalingam C Feb. 14, 2018, 2:13 p.m. UTC
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/misc/mei/Kconfig  | 6 ++++++
 drivers/misc/mei/Makefile | 2 ++
 2 files changed, 8 insertions(+)

Comments

Winkler, Tomas Feb. 14, 2018, 2:54 p.m. UTC | #1
> 
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
>  drivers/misc/mei/Kconfig  | 6 ++++++
>  drivers/misc/mei/Makefile | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
> c49e1d2269af..90977132d1e2 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -43,3 +43,9 @@ config INTEL_MEI_TXE
> 
>  	  Supported SoCs:
>  	  Intel Bay Trail
> +
> +config INTEL_MEI_HDCP
> +	tristate "Intel HDCP2.2 services of ME Interface"
> +	depends on INTEL_MEI && DRM_I915
> +	help
> +	  MEI Support for HDCP2.2 Services on Intel SoCs.
> diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile index
> cd6825afa8e1..ee19754c1aec 100644
> --- a/drivers/misc/mei/Makefile
> +++ b/drivers/misc/mei/Makefile
> @@ -23,3 +23,5 @@ mei-txe-objs += hw-txe.o
> 
>  mei-$(CONFIG_EVENT_TRACING) += mei-trace.o  CFLAGS_mei-trace.o = -
> I$(src)
> +
> +obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o

Should go to the separate directory. 
Thanks
Tomas
Ramalingam C Feb. 14, 2018, 2:58 p.m. UTC | #2
On Wednesday 14 February 2018 08:24 PM, Winkler, Tomas wrote:
>> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>> ---
>>   drivers/misc/mei/Kconfig  | 6 ++++++
>>   drivers/misc/mei/Makefile | 2 ++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
>> c49e1d2269af..90977132d1e2 100644
>> --- a/drivers/misc/mei/Kconfig
>> +++ b/drivers/misc/mei/Kconfig
>> @@ -43,3 +43,9 @@ config INTEL_MEI_TXE
>>
>>   	  Supported SoCs:
>>   	  Intel Bay Trail
>> +
>> +config INTEL_MEI_HDCP
>> +	tristate "Intel HDCP2.2 services of ME Interface"
>> +	depends on INTEL_MEI && DRM_I915
>> +	help
>> +	  MEI Support for HDCP2.2 Services on Intel SoCs.
>> diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile index
>> cd6825afa8e1..ee19754c1aec 100644
>> --- a/drivers/misc/mei/Makefile
>> +++ b/drivers/misc/mei/Makefile
>> @@ -23,3 +23,5 @@ mei-txe-objs += hw-txe.o
>>
>>   mei-$(CONFIG_EVENT_TRACING) += mei-trace.o  CFLAGS_mei-trace.o = -
>> I$(src)
>> +
>> +obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o
> Should go to the separate directory.
Sure will move it.
Thanks
--Ram
> Thanks
> Tomas
>
Ramalingam C Feb. 28, 2018, 3:43 p.m. UTC | #3
On Wednesday 14 February 2018 08:24 PM, Winkler, Tomas wrote:
>> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>> ---
>>   drivers/misc/mei/Kconfig  | 6 ++++++
>>   drivers/misc/mei/Makefile | 2 ++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
>> c49e1d2269af..90977132d1e2 100644
>> --- a/drivers/misc/mei/Kconfig
>> +++ b/drivers/misc/mei/Kconfig
>> @@ -43,3 +43,9 @@ config INTEL_MEI_TXE
>>
>>   	  Supported SoCs:
>>   	  Intel Bay Trail
>> +
>> +config INTEL_MEI_HDCP
>> +	tristate "Intel HDCP2.2 services of ME Interface"
>> +	depends on INTEL_MEI && DRM_I915
>> +	help
>> +	  MEI Support for HDCP2.2 Services on Intel SoCs.
>> diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile index
>> cd6825afa8e1..ee19754c1aec 100644
>> --- a/drivers/misc/mei/Makefile
>> +++ b/drivers/misc/mei/Makefile
>> @@ -23,3 +23,5 @@ mei-txe-objs += hw-txe.o
>>
>>   mei-$(CONFIG_EVENT_TRACING) += mei-trace.o  CFLAGS_mei-trace.o = -
>> I$(src)
>> +
>> +obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o
> Should go to the separate directory.
Instead of dedicated makefile for a single file, can I do something like

+obj-$(CONFIG_INTEL_MEI_HDCP) += hdcp/mei_hdcp.o

--Ram

> Thanks
> Tomas
>
Winkler, Tomas Feb. 28, 2018, 4:11 p.m. UTC | #4
> On Wednesday 14 February 2018 08:24 PM, Winkler, Tomas wrote:

> >> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>

> >> ---

> >>   drivers/misc/mei/Kconfig  | 6 ++++++

> >>   drivers/misc/mei/Makefile | 2 ++

> >>   2 files changed, 8 insertions(+)

> >>

> >> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig

> >> index

> >> c49e1d2269af..90977132d1e2 100644

> >> --- a/drivers/misc/mei/Kconfig

> >> +++ b/drivers/misc/mei/Kconfig

> >> @@ -43,3 +43,9 @@ config INTEL_MEI_TXE

> >>

> >>   	  Supported SoCs:

> >>   	  Intel Bay Trail

> >> +

> >> +config INTEL_MEI_HDCP

> >> +	tristate "Intel HDCP2.2 services of ME Interface"

> >> +	depends on INTEL_MEI && DRM_I915

> >> +	help

> >> +	  MEI Support for HDCP2.2 Services on Intel SoCs.

> >> diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile

> >> index cd6825afa8e1..ee19754c1aec 100644

> >> --- a/drivers/misc/mei/Makefile

> >> +++ b/drivers/misc/mei/Makefile

> >> @@ -23,3 +23,5 @@ mei-txe-objs += hw-txe.o

> >>

> >>   mei-$(CONFIG_EVENT_TRACING) += mei-trace.o  CFLAGS_mei-trace.o = -

> >> I$(src)

> >> +

> >> +obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o

> > Should go to the separate directory.

> Instead of dedicated makefile for a single file, can I do something like

> 

> +obj-$(CONFIG_INTEL_MEI_HDCP) += hdcp/mei_hdcp.o

> 

Both will work, but it should be a new Makefile as we need that separation.
Thanks
Tomas
diff mbox

Patch

diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
index c49e1d2269af..90977132d1e2 100644
--- a/drivers/misc/mei/Kconfig
+++ b/drivers/misc/mei/Kconfig
@@ -43,3 +43,9 @@  config INTEL_MEI_TXE
 
 	  Supported SoCs:
 	  Intel Bay Trail
+
+config INTEL_MEI_HDCP
+	tristate "Intel HDCP2.2 services of ME Interface"
+	depends on INTEL_MEI && DRM_I915
+	help
+	  MEI Support for HDCP2.2 Services on Intel SoCs.
diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile
index cd6825afa8e1..ee19754c1aec 100644
--- a/drivers/misc/mei/Makefile
+++ b/drivers/misc/mei/Makefile
@@ -23,3 +23,5 @@  mei-txe-objs += hw-txe.o
 
 mei-$(CONFIG_EVENT_TRACING) += mei-trace.o
 CFLAGS_mei-trace.o = -I$(src)
+
+obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o