diff mbox

drm/todo: Add idr_init_base todo

Message ID 20180219145708.23523-1-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Feb. 19, 2018, 2:57 p.m. UTC 
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/todo.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Alex Deucher Feb. 19, 2018, 4:20 p.m. UTC | #1 
On Mon, Feb 19, 2018 at 9:57 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  Documentation/gpu/todo.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 1e593370f64f..1a0a413eeced 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -212,6 +212,16 @@ probably use drm_fb_helper_fbdev_teardown().
>
>  Contact: Maintainer of the driver you plan to convert
>
> +idr_init_base()
> +---------------
> +
> +DRM core&drivers uses a lot of idr (integer lookup directories) for mapping
> +userspace IDs to internal objects, and in most places ID=0 means NULL and hence
> +is never used. Switching to idr_init_base() for these would make the idr more
> +efficient.
> +
> +Contact: Daniel Vetter
> +
>  Core refactorings
>  =================
>
> --
> 2.15.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter Feb. 19, 2018, 4:32 p.m. UTC | #2 
On Mon, Feb 19, 2018 at 03:57:08PM +0100, Daniel Vetter wrote:
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

And applied.
-Daniel

> ---
>  Documentation/gpu/todo.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 1e593370f64f..1a0a413eeced 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -212,6 +212,16 @@ probably use drm_fb_helper_fbdev_teardown().
>  
>  Contact: Maintainer of the driver you plan to convert
>  
> +idr_init_base()
> +---------------
> +
> +DRM core&drivers uses a lot of idr (integer lookup directories) for mapping
> +userspace IDs to internal objects, and in most places ID=0 means NULL and hence
> +is never used. Switching to idr_init_base() for these would make the idr more
> +efficient.
> +
> +Contact: Daniel Vetter
> +
>  Core refactorings
>  =================
>  
> -- 
> 2.15.1
>
diff mbox

Patch

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 1e593370f64f..1a0a413eeced 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -212,6 +212,16 @@  probably use drm_fb_helper_fbdev_teardown().
 
 Contact: Maintainer of the driver you plan to convert
 
+idr_init_base()
+---------------
+
+DRM core&drivers uses a lot of idr (integer lookup directories) for mapping
+userspace IDs to internal objects, and in most places ID=0 means NULL and hence
+is never used. Switching to idr_init_base() for these would make the idr more
+efficient.
+
+Contact: Daniel Vetter
+
 Core refactorings
 =================