[v5,5/5] ARM: dts: bcm2837-rpi-3-b: add GPIO expander
diff mbox

Message ID a6d59692dc4847e0b1639a26542e28c95ad5240f.1519128054.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach Feb. 20, 2018, 12:19 p.m. UTC
Add a description of the RPi3 GPIO expander that the VC4 firmware controls.

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v5:
  * Drop the 'firmware' property

v4:
  * Move the gpio node under the firmware node
  * Rename the gpio node to plain 'gpio'
  * Add Stefan's ack

v3:
  * List GPIO names one per line.

v2:
  * Move GPIO expander node out of the soc container
  * Rename compatible string
  * Add gpio-line-names property
---
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Linus Walleij Feb. 22, 2018, 12:52 p.m. UTC | #1
On Tue, Feb 20, 2018 at 1:19 PM, Baruch Siach <baruch@tkos.co.il> wrote:

> Add a description of the RPi3 GPIO expander that the VC4 firmware controls.
>
> Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v5:
>   * Drop the 'firmware' property

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Please funnel this patch through the ARM SoC tree.

Yours,
Linus Walleij
Eric Anholt Feb. 22, 2018, 8:06 p.m. UTC | #2
Linus Walleij <linus.walleij@linaro.org> writes:

> On Tue, Feb 20, 2018 at 1:19 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>
>> Add a description of the RPi3 GPIO expander that the VC4 firmware controls.
>>
>> Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> v5:
>>   * Drop the 'firmware' property
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Please funnel this patch through the ARM SoC tree.

Picked up the reviews and applied these last 2 to bcm2835-dt-next.  I
didn't see the gpio tree's for-next updated, so I didn't integration
test it personally, but hopefully our branches can come together in
-next soon.

(FWIW, I was looking at
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for
gpio)

Thanks for pushing this to completion, Baruch!

Patch
diff mbox

diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index 3e4ed7c5b0b3..0b31d995a066 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -25,6 +25,23 @@ 
 	};
 };
 
+&firmware {
+	expgpio: gpio {
+		compatible = "raspberrypi,firmware-gpio";
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names = "BT_ON",
+				  "WL_ON",
+				  "STATUS_LED",
+				  "LAN_RUN",
+				  "HPD_N",
+				  "CAM_GPIO0",
+				  "CAM_GPIO1",
+				  "PWR_LOW_N";
+		status = "okay";
+	};
+};
+
 /* uart0 communicates with the BT module */
 &uart0 {
 	pinctrl-names = "default";