drm/todo: i915 could use device_link_add
diff mbox

Message ID 20180220132017.30719-1-daniel.vetter@ffwll.ch
State New
Headers show

Commit Message

Daniel Vetter Feb. 20, 2018, 1:20 p.m. UTC
Noticed while reading some unrelated patches. Unfortunately Imre's
patch to add our early/late hooks predated the device_link
infrastructure by 2 years.

Cc: Imre Deak <imre.deak@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/todo.rst | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Imre Deak Feb. 20, 2018, 2:17 p.m. UTC | #1
On Tue, Feb 20, 2018 at 02:20:17PM +0100, Daniel Vetter wrote:
> Noticed while reading some unrelated patches. Unfortunately Imre's
> patch to add our early/late hooks predated the device_link
> infrastructure by 2 years.
> 
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Yep, good idea to convert over:
Acked-by: Imre Deak <imre.deak@intel.com>

> ---
>  Documentation/gpu/todo.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 1a0a413eeced..f4d0b3476d9c 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -450,5 +450,12 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
>  
>  Contact: Harry Wentland, Alex Deucher
>  
> +i915
> +----
> +
> +- Our early/late pm callbacks could be removed in favour of using
> +  device_link_add to model the dependency between i915 and snd_had. See
> +  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
> +
>  Outside DRM
>  ===========
> -- 
> 2.15.1
>
Daniel Vetter Feb. 20, 2018, 11:48 p.m. UTC | #2
On Tue, Feb 20, 2018 at 04:17:19PM +0200, Imre Deak wrote:
> On Tue, Feb 20, 2018 at 02:20:17PM +0100, Daniel Vetter wrote:
> > Noticed while reading some unrelated patches. Unfortunately Imre's
> > patch to add our early/late hooks predated the device_link
> > infrastructure by 2 years.
> > 
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Yep, good idea to convert over:
> Acked-by: Imre Deak <imre.deak@intel.com>

Pushed to dinq.
-Daniel

> 
> > ---
> >  Documentation/gpu/todo.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> > index 1a0a413eeced..f4d0b3476d9c 100644
> > --- a/Documentation/gpu/todo.rst
> > +++ b/Documentation/gpu/todo.rst
> > @@ -450,5 +450,12 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
> >  
> >  Contact: Harry Wentland, Alex Deucher
> >  
> > +i915
> > +----
> > +
> > +- Our early/late pm callbacks could be removed in favour of using
> > +  device_link_add to model the dependency between i915 and snd_had. See
> > +  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
> > +
> >  Outside DRM
> >  ===========
> > -- 
> > 2.15.1
> >

Patch
diff mbox

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 1a0a413eeced..f4d0b3476d9c 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -450,5 +450,12 @@  See drivers/gpu/drm/amd/display/TODO for tasks.
 
 Contact: Harry Wentland, Alex Deucher
 
+i915
+----
+
+- Our early/late pm callbacks could be removed in favour of using
+  device_link_add to model the dependency between i915 and snd_had. See
+  https://dri.freedesktop.org/docs/drm/driver-api/device_link.html
+
 Outside DRM
 ===========