diff mbox

[i-g-t,v2] tests/perf_pmu: Skip hotplug test on Broxton

Message ID 20180221105932.6781-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Feb. 21, 2018, 10:59 a.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Apollolake machine in the shards cannot bring the CPU0 back online so
skip the test on all Broxtons for now.

v2: Fix inverted check.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Feb. 21, 2018, 11 a.m. UTC | #1 
Quoting Tvrtko Ursulin (2018-02-21 10:59:32)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Apollolake machine in the shards cannot bring the CPU0 back online so
> skip the test on all Broxtons for now.
> 
> v2: Fix inverted check.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  tests/perf_pmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 0beb91976102..b9ddd0d27bce 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
>         int fd, ret;
>         int cur = 0;
>  
> +       igt_require(!IS_BROXTON(intel_get_drm_devid(gem_fd)));
>         igt_require(cpu0_hotplug_support());

igt_skip_on() then. It produces nicer output than inverting everywhere.
-Chris
diff mbox

Patch

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 0beb91976102..b9ddd0d27bce 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -966,6 +966,7 @@  static void cpu_hotplug(int gem_fd)
 	int fd, ret;
 	int cur = 0;
 
+	igt_require(!IS_BROXTON(intel_get_drm_devid(gem_fd)));
 	igt_require(cpu0_hotplug_support());
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));