dt-bindings: iio: adc: sd-modulator: fix io-channel-cells
diff mbox

Message ID 1519384041-23782-1-git-send-email-fabrice.gasnier@st.com
State New
Headers show

Commit Message

Fabrice Gasnier Feb. 23, 2018, 11:07 a.m. UTC
io-channel-cells should be <0> since sigma delta modulator exports only
one channel, as described in ../iio/iio-bindings.txt "IIO providers"
section. Only the phandle is necessary for IIO consumers in this case.

Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Arnaud POULIQUEN Feb. 23, 2018, 1:46 p.m. UTC | #1
Hello,

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Regards,
Arnaud

On 02/23/2018 12:07 PM, Fabrice Gasnier wrote:
> io-channel-cells should be <0> since sigma delta modulator exports only
> one channel, as described in ../iio/iio-bindings.txt "IIO providers"
> section. Only the phandle is necessary for IIO consumers in this case.
> 
> Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> index e9ebb8a..ba24ca7 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
>  Required properties:
>  - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
>  	as a generic SD modulator if modulator not specified in compatible list.
> -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
> +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
>  
>  Example node:
>  
>  	ads1202: adc@0 {
>  		compatible = "sd-modulator";
> -		#io-channel-cells = <1>;
> +		#io-channel-cells = <0>;
>  	};
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Feb. 24, 2018, 1:28 p.m. UTC | #2
On Fri, 23 Feb 2018 14:46:19 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:

> Hello,
> 
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> 
> Regards,
> Arnaud
> 
> On 02/23/2018 12:07 PM, Fabrice Gasnier wrote:
> > io-channel-cells should be <0> since sigma delta modulator exports only
> > one channel, as described in ../iio/iio-bindings.txt "IIO providers"
> > section. Only the phandle is necessary for IIO consumers in this case.
> > 
> > Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
> > 
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > index e9ebb8a..ba24ca7 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
> >  Required properties:
> >  - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> >  	as a generic SD modulator if modulator not specified in compatible list.
> > -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
> > +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
> >  
> >  Example node:
> >  
> >  	ads1202: adc@0 {
> >  		compatible = "sd-modulator";
> > -		#io-channel-cells = <1>;
> > +		#io-channel-cells = <0>;
> >  	};
> >   

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
index e9ebb8a..ba24ca7 100644
--- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
+++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
@@ -3,11 +3,11 @@  Device-Tree bindings for sigma delta modulator
 Required properties:
 - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
 	as a generic SD modulator if modulator not specified in compatible list.
-- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
+- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
 
 Example node:
 
 	ads1202: adc@0 {
 		compatible = "sd-modulator";
-		#io-channel-cells = <1>;
+		#io-channel-cells = <0>;
 	};