Revert "Input: synaptics - Lenovo Thinkpad T460p devices should use RMI"
diff mbox

Message ID 20180223212810.7433-1-arkadiusz.hiler@intel.com
State Under Review
Headers show

Commit Message

Arkadiusz Hiler Feb. 23, 2018, 9:28 p.m. UTC
This reverts commit 48282969826b3d3c76e908182f69724d86d995fe which
caused the following issues:

1. On T460p with BIOS version 2.22 touchpad and trackpoint stop working
after suspend-resume cycle. Due to strange state of the device another
suspend is impossible.

The following dmesg errors can be observed:
thinkpad_acpi: EC reports that Thermal Table has changed
rmi4_smbus 7-002c: failed to get SMBus version number!
rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current IRQ mask.
rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
rmi4_physical rmi4-00: Failed to suspend functions: -16
rmi4_smbus 7-002c: Failed to resume device: -16
PM: resume devices took 0.640 seconds
rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03 TX register (-16).
rmi4_physical rmi4-00: rmi_driver_clear_irq_bits: Failed to change enabled interrupts!
rmi4_physical rmi4-00: rmi_driver_set_irq_bits: Failed to change enabled interrupts!
psmouse: probe of serio3 failed with error -1

2. On another T460p with BIOS version 2.15 two finger scrolling gesture
on the touchpad stops working after suspend-resume cycle (about 75%
reproducibility, when it still works, the scrolling gesture becomes
laggy). Nothing suspicious appears in the dmesg.

Cc: Zhenjie Wang <zhenjie.wang@sjtu.edu.cn>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Tested-by: Martin Peres <martin.peres@linux.intel.com>
Tested-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Arkadiusz Hiler Feb. 28, 2018, 4:26 p.m. UTC | #1
On Fri, Feb 23, 2018 at 11:28:10PM +0200, Arkadiusz Hiler wrote:
> This reverts commit 48282969826b3d3c76e908182f69724d86d995fe which
> caused the following issues:
> 
> 1. On T460p with BIOS version 2.22 touchpad and trackpoint stop working
> after suspend-resume cycle. Due to strange state of the device another
> suspend is impossible.
> 
> The following dmesg errors can be observed:
> thinkpad_acpi: EC reports that Thermal Table has changed
> rmi4_smbus 7-002c: failed to get SMBus version number!
> rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current IRQ mask.
> rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
> rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
> rmi4_physical rmi4-00: Failed to suspend functions: -16
> rmi4_smbus 7-002c: Failed to resume device: -16
> PM: resume devices took 0.640 seconds
> rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03 TX register (-16).
> rmi4_physical rmi4-00: rmi_driver_clear_irq_bits: Failed to change enabled interrupts!
> rmi4_physical rmi4-00: rmi_driver_set_irq_bits: Failed to change enabled interrupts!
> psmouse: probe of serio3 failed with error -1
> 
> 2. On another T460p with BIOS version 2.15 two finger scrolling gesture
> on the touchpad stops working after suspend-resume cycle (about 75%
> reproducibility, when it still works, the scrolling gesture becomes
> laggy). Nothing suspicious appears in the dmesg.
> 
> Cc: Zhenjie Wang <zhenjie.wang@sjtu.edu.cn>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Tested-by: Martin Peres <martin.peres@linux.intel.com>
> Tested-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Hey,

I just found exact same revert by Richard Schütz sent earlier to the
linux-input list (<20180219193523.6287-1-rschuetz@uni-koblenz.de>).

There's also this conversation https://lkml.org/lkml/2018/2/13/68

I would appreciate if the revert would be applied soon. Constant
reapplying of the patch and recompiling the kernel just to have suspend
and pointing devices working on the T460p is pretty laborious :-)

It should also be:
Cc: stable@vger.kernel.org
Heinz Wiesinger March 1, 2018, 7:06 a.m. UTC | #2
On Wednesday, 28 February 2018 17:26:53 CET Arkadiusz Hiler wrote:
> On Fri, Feb 23, 2018 at 11:28:10PM +0200, Arkadiusz Hiler wrote:
> > This reverts commit 48282969826b3d3c76e908182f69724d86d995fe which
> > caused the following issues:
> > 
> > 1. On T460p with BIOS version 2.22 touchpad and trackpoint stop working
> > after suspend-resume cycle. Due to strange state of the device another
> > suspend is impossible.
> > 
> > The following dmesg errors can be observed:
> > thinkpad_acpi: EC reports that Thermal Table has changed
> > rmi4_smbus 7-002c: failed to get SMBus version number!
> > rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current
> > IRQ mask. rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
> > rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
> > rmi4_physical rmi4-00: Failed to suspend functions: -16
> > rmi4_smbus 7-002c: Failed to resume device: -16
> > PM: resume devices took 0.640 seconds
> > rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03 TX
> > register (-16). rmi4_physical rmi4-00: rmi_driver_clear_irq_bits: Failed
> > to change enabled interrupts! rmi4_physical rmi4-00:
> > rmi_driver_set_irq_bits: Failed to change enabled interrupts! psmouse:
> > probe of serio3 failed with error -1
> > 
> > 2. On another T460p with BIOS version 2.15 two finger scrolling gesture
> > on the touchpad stops working after suspend-resume cycle (about 75%
> > reproducibility, when it still works, the scrolling gesture becomes
> > laggy). Nothing suspicious appears in the dmesg.
> > 
> > Cc: Zhenjie Wang <zhenjie.wang@sjtu.edu.cn>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > Tested-by: Martin Peres <martin.peres@linux.intel.com>
> > Tested-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> Hey,
> 
> I just found exact same revert by Richard Schütz sent earlier to the
> linux-input list (<20180219193523.6287-1-rschuetz@uni-koblenz.de>).
> 
> There's also this conversation https://lkml.org/lkml/2018/2/13/68
> 
> I would appreciate if the revert would be applied soon. Constant
> reapplying of the patch and recompiling the kernel just to have suspend
> and pointing devices working on the T460p is pretty laborious :-)

FWIW, I also saw similar behavior here with kernel 4.14.x and my Lenovo T440s. 
It's not happening in a reproducible way for me however. Sometimes after 
resume the pointer doesn't move (and then prevents further suspends) and 
sometimes multi-touch gestures don't work (two finger click, etc). Both cases 
happen rather rarely, but they do happen.

Grs,
Heinz

Patch
diff mbox

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 3d2e23a0ae39..a246fc686bb7 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -173,7 +173,6 @@  static const char * const smbus_pnp_ids[] = {
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
 	"LEN200f", /* T450s */
-	"LEN2018", /* T460p */
 	NULL
 };