diff mbox

v4.16-rc0: missing includes in framebuffers break N900 compilation

Message ID 20180226130007.GA5634@amd (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek Feb. 26, 2018, 1 p.m. UTC
I needed this to get -rc0 to compile.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Tomi Valkeinen Feb. 26, 2018, 2:05 p.m. UTC | #1
v4.16-rc1 has a fix (b9058afcd6c7).

 Tomi

On 26/02/18 15:00, Pavel Machek wrote:
> I needed this to get -rc0 to compile.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> index 48c6500..990f1c9 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> @@ -38,6 +38,7 @@
>  #include <linux/regmap.h>
>  #include <linux/of.h>
>  #include <linux/regulator/consumer.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/suspend.h>
>  #include <linux/component.h>
>  
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> index 9a13c35..4862b12 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> @@ -12,6 +12,7 @@
>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/platform_device.h>
> +#include <linux/seq_file.h>
>  #include <linux/slab.h>
>  #include <video/omapfb_dss.h>
>  
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> index eac3665..39014e2 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> @@ -15,6 +15,7 @@
>  #include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/platform_device.h>
> +#include <linux/seq_file.h>
>  #include <linux/clk.h>
>  
>  #include <video/omapfb_dss.h>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> index 705373e..e93e7a7 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> @@ -15,6 +15,7 @@
>  #include <linux/io.h>
>  #include <linux/platform_device.h>
>  #include <video/omapfb_dss.h>
> +#include <linux/seq_file.h>
>  
>  #include "dss.h"
>  #include "hdmi.h"
>
Pavel Machek March 2, 2018, 9:12 a.m. UTC | #2
On Mon 2018-02-26 16:05:53, Tomi Valkeinen wrote:
> v4.16-rc1 has a fix (b9058afcd6c7).

Yep, thanks. I was bisecting sound problem on N900, so this hit me...

     	       	   	     	   	      	       	    Pavel

> On 26/02/18 15:00, Pavel Machek wrote:
> > I needed this to get -rc0 to compile.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > 
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > index 48c6500..990f1c9 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > @@ -38,6 +38,7 @@
> >  #include <linux/regmap.h>
> >  #include <linux/of.h>
> >  #include <linux/regulator/consumer.h>
> > +#include <linux/pinctrl/consumer.h>
> >  #include <linux/suspend.h>
> >  #include <linux/component.h>
> >  
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > index 9a13c35..4862b12 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > @@ -12,6 +12,7 @@
> >  #include <linux/err.h>
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/seq_file.h>
> >  #include <linux/slab.h>
> >  #include <video/omapfb_dss.h>
> >  
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > index eac3665..39014e2 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/err.h>
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/seq_file.h>
> >  #include <linux/clk.h>
> >  
> >  #include <video/omapfb_dss.h>
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > index 705373e..e93e7a7 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> >  #include <video/omapfb_dss.h>
> > +#include <linux/seq_file.h>
> >  
> >  #include "dss.h"
> >  #include "hdmi.h"
> > 
>
diff mbox

Patch

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
index 48c6500..990f1c9 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
@@ -38,6 +38,7 @@ 
 #include <linux/regmap.h>
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/suspend.h>
 #include <linux/component.h>
 
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
index 9a13c35..4862b12 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
@@ -12,6 +12,7 @@ 
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/slab.h>
 #include <video/omapfb_dss.h>
 
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
index eac3665..39014e2 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
@@ -15,6 +15,7 @@ 
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/platform_device.h>
+#include <linux/seq_file.h>
 #include <linux/clk.h>
 
 #include <video/omapfb_dss.h>
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
index 705373e..e93e7a7 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
@@ -15,6 +15,7 @@ 
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"