| Message ID | 20180228191828.20056-3-nayna@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Feb 28, 2018 at 02:18:28PM -0500, Nayna Jain wrote: > When 'commit 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() > in TPM 1.2/2.0 generic drivers")' was upstreamed, it replaced the "was upstreamed" is redundant information. If you speak about commit ID, it is expected to be in the mainline. Why there is "'" before the word 'commit'? Just write In commit 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers")' msleep() was replaced with usleep_range(). > msleep() calls with usleep_range(), but did not change the > granularity of the calls. They're still defined in terms of msec. > Test results show that refining the granularity further improves > the performance. We're posting this patch as an RFC to show that there > needs to be another function which allows finer granularity. > > After this change, performance on a TPM 1.2 with an 8 byte > burstcount for 1000 extends improved from ~10.7sec to ~6.9sec. Environment where this result was achieved would be mandatory. > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> > --- > drivers/char/tpm/tpm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 7e797377e1eb..8cad6bfc5f46 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -522,8 +522,7 @@ int tpm_pm_resume(struct device *dev); > > static inline void tpm_msleep(unsigned int delay_msec) > { > - usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US, > - delay_msec * 1000); > + usleep_range((delay_msec * 1000) / 10, (delay_msec * 1000) / 2); Shouldn't the max be 'delay_msec * 1000'? Where do these numbers come from? /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/01/2018 03:28 PM, Jarkko Sakkinen wrote: > On Wed, Feb 28, 2018 at 02:18:28PM -0500, Nayna Jain wrote: >> When 'commit 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() >> in TPM 1.2/2.0 generic drivers")' was upstreamed, it replaced the > "was upstreamed" is redundant information. If you speak about commit ID, > it is expected to be in the mainline. Why there is "'" before the word > 'commit'? > > Just write > > In commit 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() > in TPM 1.2/2.0 generic drivers")' msleep() was replaced with > usleep_range(). Yeah. Sure. Will do. > >> msleep() calls with usleep_range(), but did not change the >> granularity of the calls. They're still defined in terms of msec. >> Test results show that refining the granularity further improves >> the performance. We're posting this patch as an RFC to show that there >> needs to be another function which allows finer granularity. >> >> After this change, performance on a TPM 1.2 with an 8 byte >> burstcount for 1000 extends improved from ~10.7sec to ~6.9sec. > Environment where this result was achieved would be mandatory. Sure. It is an x86 based, locked down, single purpose closed system. It has Infineon TPM 1.2 using LPC Bus. > >> Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> >> --- >> drivers/char/tpm/tpm.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h >> index 7e797377e1eb..8cad6bfc5f46 100644 >> --- a/drivers/char/tpm/tpm.h >> +++ b/drivers/char/tpm/tpm.h >> @@ -522,8 +522,7 @@ int tpm_pm_resume(struct device *dev); >> >> static inline void tpm_msleep(unsigned int delay_msec) >> { >> - usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US, >> - delay_msec * 1000); >> + usleep_range((delay_msec * 1000) / 10, (delay_msec * 1000) / 2); > Shouldn't the max be 'delay_msec * 1000'? Where do these numbers > come from? We don’t expect the patch to be upstreamed as is with the /10 and /2. Our point in posting this was to show that msec is the wrong granularity for polling. And so we suggest to have another sleep() function which can take timeouts in usecs. The way timeouts are used in the driver is to sleep between polling for a specified amount of time. Since not all TPM commands take the same time to execute, some of them might return much earlier than others. In such cases, having those TPM commands use a polling granularity of msecs is wrong, and adds cumulative delays. Since the polling loops for a specified amount of time, which is defined by TCG Specification for each command, changing the granularity for polling should not cause problems. To obtain the performance improvements in the specified environment, minimizing the minimum value of usleep_range() wasn’t enough. We found that changing the maximum value by /2 gave a dramatic improvement, and pointed us in the direction of using a smaller granularity. Thanks & Regards, - Nayna > > /Jarkko > -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index 7e797377e1eb..8cad6bfc5f46 100644 --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -522,8 +522,7 @@ int tpm_pm_resume(struct device *dev); static inline void tpm_msleep(unsigned int delay_msec) { - usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US, - delay_msec * 1000); + usleep_range((delay_msec * 1000) / 10, (delay_msec * 1000) / 2); }; struct tpm_chip *tpm_chip_find_get(struct tpm_chip *chip);
When 'commit 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers")' was upstreamed, it replaced the msleep() calls with usleep_range(), but did not change the granularity of the calls. They're still defined in terms of msec. Test results show that refining the granularity further improves the performance. We're posting this patch as an RFC to show that there needs to be another function which allows finer granularity. After this change, performance on a TPM 1.2 with an 8 byte burstcount for 1000 extends improved from ~10.7sec to ~6.9sec. Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> --- drivers/char/tpm/tpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)