arm: dts: omap3: Add missing #sound-dai-cells
diff mbox

Message ID 20180301202537.30571-2-robh@kernel.org
State New
Headers show

Commit Message

Rob Herring March 1, 2018, 8:25 p.m. UTC
dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Cc: "Benoît Cousson" <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/boot/dts/omap3.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Tony Lindgren March 1, 2018, 10:32 p.m. UTC | #1
* Rob Herring <robh@kernel.org> [180301 12:26]:
> dtc now gives the following warnings:
> 
> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> 
> Add the missing #sound-dai-cells property.

Is this needed for the current -rc or is v4.17 OK?

Somehow I'm not seeing these with current -rc or next, is
there some special option (not W=2 :) that you're using?

Regards,

Tony

> Cc: "Benoît Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/boot/dts/omap3.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index a005802cd52b..4043ecb38016 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -557,6 +557,7 @@
>  			dma-names = "tx", "rx";
>  			clocks = <&mcbsp4_fck>;
>  			clock-names = "fck";
> +			#sound-dai-cells = <0>;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.14.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring March 1, 2018, 11:28 p.m. UTC | #2
On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Rob Herring <robh@kernel.org> [180301 12:26]:
>> dtc now gives the following warnings:
>>
>> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>>
>> Add the missing #sound-dai-cells property.
>
> Is this needed for the current -rc or is v4.17 OK?

4.17 is fine.

> Somehow I'm not seeing these with current -rc or next, is
> there some special option (not W=2 :) that you're using?

Upstream dtc which I'm working on syncing to for 4.17.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren March 1, 2018, 11:33 p.m. UTC | #3
* Rob Herring <robh@kernel.org> [180301 23:29]:
> On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Rob Herring <robh@kernel.org> [180301 12:26]:
> >> dtc now gives the following warnings:
> >>
> >> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> >> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> >> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> >>
> >> Add the missing #sound-dai-cells property.
> >
> > Is this needed for the current -rc or is v4.17 OK?
> 
> 4.17 is fine.
> 
> > Somehow I'm not seeing these with current -rc or next, is
> > there some special option (not W=2 :) that you're using?
> 
> Upstream dtc which I'm working on syncing to for 4.17.

OK let me know if you want to queue along with your other
changes and I'll ack or else I'll apply it up tomorrow.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring March 5, 2018, 7:41 p.m. UTC | #4
On Thu, Mar 1, 2018 at 5:33 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Rob Herring <robh@kernel.org> [180301 23:29]:
>> On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Rob Herring <robh@kernel.org> [180301 12:26]:
>> >> dtc now gives the following warnings:
>> >>
>> >> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>> >> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>> >> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>> >>
>> >> Add the missing #sound-dai-cells property.
>> >
>> > Is this needed for the current -rc or is v4.17 OK?
>>
>> 4.17 is fine.
>>
>> > Somehow I'm not seeing these with current -rc or next, is
>> > there some special option (not W=2 :) that you're using?
>>
>> Upstream dtc which I'm working on syncing to for 4.17.
>
> OK let me know if you want to queue along with your other
> changes and I'll ack or else I'll apply it up tomorrow.

Please apply it.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index a005802cd52b..4043ecb38016 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -557,6 +557,7 @@ 
 			dma-names = "tx", "rx";
 			clocks = <&mcbsp4_fck>;
 			clock-names = "fck";
+			#sound-dai-cells = <0>;
 			status = "disabled";
 		};