diff mbox

[Bug,101900] No HDMI HBR audio on Polaris (no TrueHD, no Atmos, no Neo:X, no HD Master audio) and static noise in sound when LPCM on amdgpu Xorg driver

Message ID bug-101900-502-GzOOaXHRD5@http.bugs.freedesktop.org/ (mailing list archive)
State New, archived
Headers show

Commit Message

bugzilla-daemon@freedesktop.org March 4, 2018, 9:48 p.m. UTC 
https://bugs.freedesktop.org/show_bug.cgi?id=101900

--- Comment #31 from Andrew Nelson <andrew.s.nelson@gmail.com> ---
I have been running into the same issue. The problem seems to be that AMDGPU is
reporting that it supports 7 speakers instead of 8 in the EID. HBR formats work
with 5.1 encoded audio, but not 7.1. For some reason, the driver is configured
to subtract 1 from the channel count before passing it into the EID. I have
removed this and confirmed that 7.1 HBR audio works. Patch below:
diff mbox

Patch

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
index 8bfb4577b4d5..5dcc685a1379 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
@@ -557,7 +557,7 @@  void dce_aud_az_configure(

                        /* fill audio format data */
                        set_reg_field_value(value,
-                                       audio_mode->channel_count - 1,
+                                       audio_mode->channel_count,
                                       
AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0,
                                        MAX_CHANNELS);