Patchwork [next] crypto: x86/des3_ede: make array des3_ede_skciphers static

login
register
mail settings
Submitter Colin Ian King
Date March 5, 2018, 1:18 p.m.
Message ID <20180305131800.26647-1-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/10258911/
State Not Applicable
Delegated to: Herbert Xu
Headers show

Comments

Colin Ian King - March 5, 2018, 1:18 p.m.
From: Colin Ian King <colin.king@canonical.com>

The array des3_ede_skciphers is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
arch/x86/crypto/des3_ede_glue.c:407:21: warning: symbol
'des3_ede_skciphers' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/crypto/des3_ede_glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Herbert Xu - March 16, 2018, 3:35 p.m.
On Mon, Mar 05, 2018 at 02:18:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array des3_ede_skciphers is local to the source and does not need
> to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> arch/x86/crypto/des3_ede_glue.c:407:21: warning: symbol
> 'des3_ede_skciphers' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This patch no longer applies because it's already been merged
from someone else.

Thanks,

Patch

diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede_glue.c
index f9c7bdc5be5a..5c610d4ef9fc 100644
--- a/arch/x86/crypto/des3_ede_glue.c
+++ b/arch/x86/crypto/des3_ede_glue.c
@@ -404,7 +404,7 @@  static struct crypto_alg des3_ede_cipher = {
 	}
 };
 
-struct skcipher_alg des3_ede_skciphers[] = {
+static struct skcipher_alg des3_ede_skciphers[] = {
 	{
 		.base.cra_name		= "ecb(des3_ede)",
 		.base.cra_driver_name	= "ecb-des3_ede-asm",