| Message ID | 20180305231507.10386-6-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
On 03/06/2018 12:14 AM, Martin Wilck wrote: > Updating the prio values for printing makes no sense. The user wants to see > the prio values multipath is actually using for path group selection, and > updating the values here means actually lying to the user if the prio values > have changed, but multipathd hasn't updated them internally. > > If we really don't update the pathgroup prios when we need to, this should be > fixed elsewhere. The current wrong output would just hide that if it occured. > > Moreover, correctness forbids changing properties so deeply in a code path > that's supposed to print them only. Finally, this piece of code prevents the > print.c code to be converted to proper "const" usage. > > Signed-off-by: Martin Wilck <mwilck@suse.com> > Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com> > --- > libmultipath/print.c | 7 ------- > 1 file changed, 7 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/libmultipath/print.c b/libmultipath/print.c index 8fb5c5058965..b5c00bfe69a5 100644 --- a/libmultipath/print.c +++ b/libmultipath/print.c @@ -484,13 +484,6 @@ snprint_pg_selector (char * buff, size_t len, struct pathgroup * pgp) static int snprint_pg_pri (char * buff, size_t len, struct pathgroup * pgp) { - /* - * path group priority is not updated for every path prio change, - * but only on switch group code path. - * - * Printing is another reason to update. - */ - path_group_prio_update(pgp); return snprint_int(buff, len, pgp->priority); }