From patchwork Wed Mar 7 09:48:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10263711 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DC63D60247 for ; Wed, 7 Mar 2018 09:49:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE49C29480 for ; Wed, 7 Mar 2018 09:49:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C263229482; Wed, 7 Mar 2018 09:49:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66C0129480 for ; Wed, 7 Mar 2018 09:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088AbeCGJtm (ORCPT ); Wed, 7 Mar 2018 04:49:42 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:53489 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbeCGJtl (ORCPT ); Wed, 7 Mar 2018 04:49:41 -0500 Received: by mail-it0-f67.google.com with SMTP id w63so2569104ita.3; Wed, 07 Mar 2018 01:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5n35nGiw0RmITP712OBpHKx6AoC9juyr2Ec+X0wMfG8=; b=lPBsutmTUel/v+N1cGZ29N4uQfTXm5UTTkJtfiTFkBXB62LhUyJ7b1ia+vhlluJVDl OZHv1/9mHcIkdnz8Ny8aJYAhghtFS6IIjnTfvio20IqusvtK6l7AVArn18DH/hSyJXBF EHQaboKkKnGIMeBUsQTDqwJo+x+/AE1ay2wzstbkQ0B4yAxIdJTHtJWW0RlKjC/lvrZq X7ekJXvBG3BrZG+8A+n0R8P3cwffdqHHsRVc6k5LNaTnUx2D0dk5ATOVxlicJDXuPgOP /0cxJnb+FhJK7PRGIvUnHe9cpJVK5bjoENj3wufqwShJWjKtAGJBZA75ghQXPImy9hkS 7LrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5n35nGiw0RmITP712OBpHKx6AoC9juyr2Ec+X0wMfG8=; b=hHSltuDGB97ZIAuTRIfXHvOEoiSrL88Lq1mAKsy4gBel2GA/beJuvitnBqbyx6x8Z1 sULhaWklscs5TZvU2vuHCweOxx498SYy4gGno4851MFAfRKldNdgME/xI8Xczz4f+aKZ 10CIVOjOfn36axFrCPgrlBxgOc0OILlMSRgdNE2cWg3vhy+Zl1ApM2tMkM526eDi9+fo GSUluiTNsDm+fC50UJbQwF2pZ804dnVISgAVcbqbKJbcAwz4KRAKK5T/6C0x4hj+5IOV pJVb0X1SIlmqcFPgzV1yg70BUEgdN4sRlg6vTZYCKdJr0bbS22PkF1Q6WOPCLix3Cptd J37Q== X-Gm-Message-State: AElRT7Eku52wuV4CemOwxQ54g7kymLn9F4jZoGeHrYOjKQbiNvMdKMhq x8CU/+eVSf3Z3iLl67OG3VyGZA== X-Google-Smtp-Source: AG47ELub+EtR8rEXdAzNChKVnPfU+uvIkL/ha89Mf7+wMXZ60K8psJidIHY92n8YK7EgTjX3CSGZLw== X-Received: by 10.36.55.70 with SMTP id r67mr23163279itr.40.1520416180593; Wed, 07 Mar 2018 01:49:40 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id 199sm5752759itl.1.2018.03.07.01.49.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Mar 2018 01:49:39 -0800 (PST) From: Arvind Yadav To: nab@linux-iscsi.org Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH] target: tcm_loop: use put_device() if device_register fail Date: Wed, 7 Mar 2018 15:18:51 +0530 Message-Id: <4903df0f8cc170db01c65ead87d3b7af9fa269c8.1520415984.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/target/loopback/tcm_loop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 9cd4ffe..5dffc55 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -412,6 +412,7 @@ static int tcm_loop_setup_hba_bus(struct tcm_loop_hba *tl_hba, int tcm_loop_host ret = device_register(&tl_hba->dev); if (ret) { pr_err("device_register() failed for tl_hba->dev: %d\n", ret); + put_device(&tl_hba->dev); return -ENODEV; }