| Message ID | 20180307124704.24616-1-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/03/2018 12:47, Michal Wajdeczko wrote: > Header intel_ringbuffer.h is using definitions from i915_reg.h > but forget to include it. Remove this hidden dependency by > explicitly include missing header. > > v2: add reminder (Chris) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #1 Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > drivers/gpu/drm/i915/intel_ringbuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h > index 26605f3..e4933dd 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.h > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h > @@ -7,6 +7,7 @@ > #include "i915_gem_batch_pool.h" > #include "i915_gem_timeline.h" > > +#include "i915_reg.h" /* FIXME split out i915_gpu_commands.h */ > #include "i915_pmu.h" > #include "i915_request.h" > #include "i915_selftest.h" >
Quoting Michal Wajdeczko (2018-03-07 12:47:04) > Error state management code was moved into separate .c unit > but we didn't move related definitions into own header. > > v2: move also intel_display_error_state forward decl > fix ("Prefer 'unsigned int' to bare use of 'unsigned'") > warnings detected by checkpatch in moved code (Michal) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
Quoting Michal Wajdeczko (2018-03-07 12:47:01) > Header intel_ringbuffer.h is using definitions from i915_reg.h > but forget to include it. Remove this hidden dependency by > explicitly include missing header. > > v2: add reminder (Chris) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #1 Patchwork decided not to pick up this series. Could you collate the r-b and resend? -Chris
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h index 26605f3..e4933dd 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.h +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h @@ -7,6 +7,7 @@ #include "i915_gem_batch_pool.h" #include "i915_gem_timeline.h" +#include "i915_reg.h" /* FIXME split out i915_gpu_commands.h */ #include "i915_pmu.h" #include "i915_request.h" #include "i915_selftest.h"