[RFC,3/3] ext4: do not allow mount with test_dummy_encryption if encrypt not set
diff mbox

Message ID 20180309075312.62357-4-shengyong1@huawei.com
State Not Applicable
Headers show

Commit Message

Sheng Yong March 9, 2018, 7:53 a.m. UTC
When mounting with test_dummy_encryption option, if encrypt feature
is not set, return fail instead of setting encrypt feature forcely.

CC: linux-ext4@vger.kernel.org
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
 fs/ext4/super.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Patch
diff mbox

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 39bf464c35f1..c424af0ccda9 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4151,8 +4151,9 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 
 	if (DUMMY_ENCRYPTION_ENABLED(sbi) && !sb_rdonly(sb) &&
 	    !ext4_has_feature_encrypt(sb)) {
-		ext4_set_feature_encrypt(sb);
-		ext4_commit_super(sb, 1);
+		ext4_msg(sb, KERN_ERR,
+			 "Encrypt does not support or filesystem is read-only");
+		goto failed_mount_wq;
 	}
 
 	/*