Message ID | 20180309222204.4771-1-linux@rainbow-software.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, 09 Mar 2018, Ondrej Zary <linux@rainbow-software.org> wrote: > Radiant P845 does not have LVDS, only VGA. Hi, thanks for the patch. Would you mind filing a bug at [1], stating the issue here, and attaching dmesg from boot with drm.debug=14 set, as well as /sys/kernel/debug/dri/0/i915_vbt. I'd just like to have a bit more background info to look at before pushing that patch. And then we can reference the bug for posterity. Thanks, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org> > --- > drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > index ef80499113ee..6939e63d8bae 100644 > --- a/drivers/gpu/drm/i915/intel_lvds.c > +++ b/drivers/gpu/drm/i915/intel_lvds.c > @@ -819,6 +819,14 @@ static const struct dmi_system_id intel_no_lvds[] = { > DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"), > }, > }, > + { > + .callback = intel_no_lvds_dmi_callback, > + .ident = "Radiant P845", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Radiant Systems Inc"), > + DMI_MATCH(DMI_PRODUCT_NAME, "P845"), > + }, > + }, > > { } /* terminating entry */ > };
Hello, any news about this patch? The bug is rotting here: https://bugs.freedesktop.org/show_bug.cgi?id=105468 On Monday 12 March 2018 08:25:34 Jani Nikula wrote: > On Fri, 09 Mar 2018, Ondrej Zary <linux@rainbow-software.org> wrote: > > Radiant P845 does not have LVDS, only VGA. > > Hi, thanks for the patch. Would you mind filing a bug at [1], stating > the issue here, and attaching dmesg from boot with drm.debug=14 set, as > well as /sys/kernel/debug/dri/0/i915_vbt. I'd just like to have a bit > more background info to look at before pushing that patch. And then we > can reference the bug for posterity. > > Thanks, > Jani. > > > [1] > https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org> > > --- > > drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c > > b/drivers/gpu/drm/i915/intel_lvds.c index ef80499113ee..6939e63d8bae > > 100644 > > --- a/drivers/gpu/drm/i915/intel_lvds.c > > +++ b/drivers/gpu/drm/i915/intel_lvds.c > > @@ -819,6 +819,14 @@ static const struct dmi_system_id intel_no_lvds[] = > > { DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"), > > }, > > }, > > + { > > + .callback = intel_no_lvds_dmi_callback, > > + .ident = "Radiant P845", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Radiant Systems Inc"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "P845"), > > + }, > > + }, > > > > { } /* terminating entry */ > > };
On Tue, 10 Apr 2018, Ondrej Zary <linux@rainbow-software.org> wrote: > Hello, > any news about this patch? The bug is rotting here: > https://bugs.freedesktop.org/show_bug.cgi?id=105468 I'm afraid we've failed to make the connection between the bug and the patch until now. Sorry about that. BR, Jani. > > On Monday 12 March 2018 08:25:34 Jani Nikula wrote: >> On Fri, 09 Mar 2018, Ondrej Zary <linux@rainbow-software.org> wrote: >> > Radiant P845 does not have LVDS, only VGA. >> >> Hi, thanks for the patch. Would you mind filing a bug at [1], stating >> the issue here, and attaching dmesg from boot with drm.debug=14 set, as >> well as /sys/kernel/debug/dri/0/i915_vbt. I'd just like to have a bit >> more background info to look at before pushing that patch. And then we >> can reference the bug for posterity. >> >> Thanks, >> Jani. >> >> >> [1] >> https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel >> >> > Signed-off-by: Ondrej Zary <linux@rainbow-software.org> >> > --- >> > drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ >> > 1 file changed, 8 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/i915/intel_lvds.c >> > b/drivers/gpu/drm/i915/intel_lvds.c index ef80499113ee..6939e63d8bae >> > 100644 >> > --- a/drivers/gpu/drm/i915/intel_lvds.c >> > +++ b/drivers/gpu/drm/i915/intel_lvds.c >> > @@ -819,6 +819,14 @@ static const struct dmi_system_id intel_no_lvds[] = >> > { DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"), >> > }, >> > }, >> > + { >> > + .callback = intel_no_lvds_dmi_callback, >> > + .ident = "Radiant P845", >> > + .matches = { >> > + DMI_MATCH(DMI_SYS_VENDOR, "Radiant Systems Inc"), >> > + DMI_MATCH(DMI_PRODUCT_NAME, "P845"), >> > + }, >> > + }, >> > >> > { } /* terminating entry */ >> > };
On Fri, Mar 09, 2018 at 11:22:04PM +0100, Ondrej Zary wrote: > Radiant P845 does not have LVDS, only VGA. > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org> Since we failed with the VBT approach I've gone and pushed this as is to dinq (with cc:stable and the bugzilla link added). Thanks for the patch. > --- > drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > index ef80499113ee..6939e63d8bae 100644 > --- a/drivers/gpu/drm/i915/intel_lvds.c > +++ b/drivers/gpu/drm/i915/intel_lvds.c > @@ -819,6 +819,14 @@ static const struct dmi_system_id intel_no_lvds[] = { > DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"), > }, > }, > + { > + .callback = intel_no_lvds_dmi_callback, > + .ident = "Radiant P845", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Radiant Systems Inc"), > + DMI_MATCH(DMI_PRODUCT_NAME, "P845"), > + }, > + }, > > { } /* terminating entry */ > }; > -- > Ondrej Zary > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index ef80499113ee..6939e63d8bae 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -819,6 +819,14 @@ static const struct dmi_system_id intel_no_lvds[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Radiant P845", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Radiant Systems Inc"), + DMI_MATCH(DMI_PRODUCT_NAME, "P845"), + }, + }, { } /* terminating entry */ };
Radiant P845 does not have LVDS, only VGA. Signed-off-by: Ondrej Zary <linux@rainbow-software.org> --- drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ 1 file changed, 8 insertions(+)