| Message ID | 1520802470-17374-2-git-send-email-s.mesoraca16@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Headers | show |
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: > Avoid VLA[1] by using an already allocated buffer passed > by the caller. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com> > --- Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
From: Salvatore Mesoraca <s.mesoraca16@gmail.com> Date: Sun, 11 Mar 2018 22:07:50 +0100 > Avoid VLA[1] by using an already allocated buffer passed > by the caller. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com> Also applied, thanks.
diff --git a/net/rds/connection.c b/net/rds/connection.c index f80792c..abef75d 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -578,9 +578,9 @@ static void rds_walk_conn_path_info(struct socket *sock, unsigned int len, struct rds_info_iterator *iter, struct rds_info_lengths *lens, int (*visitor)(struct rds_conn_path *, void *), + u64 *buffer, size_t item_len) { - u64 buffer[(item_len + 7) / 8]; struct hlist_head *head; struct rds_connection *conn; size_t i; @@ -649,8 +649,11 @@ static void rds_conn_info(struct socket *sock, unsigned int len, struct rds_info_iterator *iter, struct rds_info_lengths *lens) { + u64 buffer[(sizeof(struct rds_info_connection) + 7) / 8]; + rds_walk_conn_path_info(sock, len, iter, lens, rds_conn_info_visitor, + buffer, sizeof(struct rds_info_connection)); }
Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com> --- net/rds/connection.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)