| Message ID | 20180313164637.781c48d2@canb.auug.org.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index d4d1d2e7e233..df2a312ca6c9 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -3827,12 +3827,14 @@ static int smu7_notify_link_speed_change_after_state_change( smu7_get_current_pcie_speed(hwmgr) > 0) return 0; +#ifdef CONFIG_ACPI if (amdgpu_acpi_pcie_performance_request(hwmgr->adev, request, false)) { if (PP_PCIEGen2 == target_link_speed) pr_info("PSPP request to switch to Gen2 from Gen3 Failed!"); else pr_info("PSPP request to switch to Gen1 from Gen2 Failed!"); } +#endif } return 0;
Hi all, After merging the drm tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_notify_link_speed_change_after_state_change': drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3830:7: error: implicit declaration of function 'amdgpu_acpi_pcie_performance_request'; did you mean 'smu7_pcie_performance_request'? [-Werror=implicit-function-declaration] if (amdgpu_acpi_pcie_performance_request(hwmgr->adev, request, false)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ smu7_pcie_performance_request Caused by commit e1deba285156 ("drm/amd/pp: Use amdgpu acpi helper functions in powerplay") and commit 37a94791a097 ("drm/amd/pp: Add #ifdef checks for CONFIG_ACPI") missed this instance. I added this hack patch for today: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 13 Mar 2018 16:24:31 +1100 Subject: [PATCH] drm/amd/pp: add another CONFIG_ACPI check Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 ++ 1 file changed, 2 insertions(+)