diff mbox

[v3,04/10] otm

Message ID 1520949014-21468-8-git-send-email-yannick.fertre@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yannick FERTRE March 13, 2018, 1:50 p.m. UTC 
---
 drivers/video/orisetech_otm8009a.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Patrice CHOTARD March 13, 2018, 2:12 p.m. UTC | #1 
Hi Yannick

There is a problem with patch 4. I received two patches 04/10, this one 
and [PATCH v3 04/10] video: add support of panel OTM8009A.

Patrice

On 03/13/2018 02:50 PM, yannick fertre wrote:
> ---

>   drivers/video/orisetech_otm8009a.c | 4 +++-

>   1 file changed, 3 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/video/orisetech_otm8009a.c b/drivers/video/orisetech_otm8009a.c

> index 81b11d7..aa8139a 100644

> --- a/drivers/video/orisetech_otm8009a.c

> +++ b/drivers/video/orisetech_otm8009a.c

> @@ -289,9 +289,11 @@ static int otm8009a_panel_probe(struct udevice *dev)

>   	struct otm8009a_panel_priv *priv = dev_get_priv(dev);

>   	int ret;

>   

> -	/* reset panel must be done before probe */

> +	/* reset panel */

>   	dm_gpio_set_value(&priv->reset, true);

>   

> +	mdelay(1);

> +

>   	if (IS_ENABLED(CONFIG_DM_REGULATOR) && priv->reg) {

>   		dev_err(dev, "enable regulator '%s'\n", priv->reg->name);

>   		ret = regulator_set_enable(priv->reg, true);

>
Yannick FERTRE March 13, 2018, 2:36 p.m. UTC | #2 
Hi,

Sorry, I send more than 10 patches.

I will remove this dummy patches tomorrow with next version.



On 03/13/2018 03:12 PM, Patrice CHOTARD wrote:
> Hi Yannick

>

> There is a problem with patch 4. I received two patches 04/10, this one

> and [PATCH v3 04/10] video: add support of panel OTM8009A.

>

> Patrice

>

> On 03/13/2018 02:50 PM, yannick fertre wrote:

>> ---

>>    drivers/video/orisetech_otm8009a.c | 4 +++-

>>    1 file changed, 3 insertions(+), 1 deletion(-)

>>

>> diff --git a/drivers/video/orisetech_otm8009a.c b/drivers/video/orisetech_otm8009a.c

>> index 81b11d7..aa8139a 100644

>> --- a/drivers/video/orisetech_otm8009a.c

>> +++ b/drivers/video/orisetech_otm8009a.c

>> @@ -289,9 +289,11 @@ static int otm8009a_panel_probe(struct udevice *dev)

>>    	struct otm8009a_panel_priv *priv = dev_get_priv(dev);

>>    	int ret;

>>    

>> -	/* reset panel must be done before probe */

>> +	/* reset panel */

>>    	dm_gpio_set_value(&priv->reset, true);

>>    

>> +	mdelay(1);

>> +

>>    	if (IS_ENABLED(CONFIG_DM_REGULATOR) && priv->reg) {

>>    		dev_err(dev, "enable regulator '%s'\n", priv->reg->name);

>>    		ret = regulator_set_enable(priv->reg, true);
diff mbox

Patch

diff --git a/drivers/video/orisetech_otm8009a.c b/drivers/video/orisetech_otm8009a.c
index 81b11d7..aa8139a 100644
--- a/drivers/video/orisetech_otm8009a.c
+++ b/drivers/video/orisetech_otm8009a.c
@@ -289,9 +289,11 @@  static int otm8009a_panel_probe(struct udevice *dev)
 	struct otm8009a_panel_priv *priv = dev_get_priv(dev);
 	int ret;
 
-	/* reset panel must be done before probe */
+	/* reset panel */
 	dm_gpio_set_value(&priv->reset, true);
 
+	mdelay(1);
+
 	if (IS_ENABLED(CONFIG_DM_REGULATOR) && priv->reg) {
 		dev_err(dev, "enable regulator '%s'\n", priv->reg->name);
 		ret = regulator_set_enable(priv->reg, true);